Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: elevate node-clinic diagnostic tier #42802

Closed
wants to merge 1 commit into from
Closed

doc: elevate node-clinic diagnostic tier #42802

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

Fixes: nodejs/diagnostics#537.

As discussed in the last Diagnostics WG(nodejs/diagnostics#552). I'm not sure how the node-clinic tests could be integrated into the nightly CI.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 20, 2022
@richardlau richardlau requested a review from a team April 20, 2022 16:38
@richardlau
Copy link
Member

As per https://github.com/nodejs/node/blob/master/doc/contributing/diagnostic-tooling-support-tiers.md#adding-a-tool-to-this-list

Once it has been added to the list "promotion" to Tier 3 through Tier 1 requires that the requirements listed above be met AND have agreement from Diagnostics WG and Release WG based on the criteria listed above.

cc @nodejs/diagnostics @nodejs/releasers

@richardlau
Copy link
Member

I'm not sure how the node-clinic tests could be integrated into the nightly CI.

Me neither. I think we test it in CITGM but that isn't run nightly.

@gireeshpunathil
Copy link
Member

I would consider if possible run in nightly clause to be same in spirit as running in CITGM

mcollina
mcollina approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gireeshpunathil gireeshpunathil mentioned this pull request Apr 21, 2022
Closed
@richardlau
Copy link
Member

I would consider if possible run in nightly clause to be same in spirit as running in CITGM

FWIW clinic is currently skipped in citgm for AIX and Windows: https://github.com/nodejs/citgm/blob/fcfc781e72e6ed79ccd8a4e189960111c55f722a/lib/lookup.json#L97-L102

@mhdawson
Copy link
Member

I would consider if possible run in nightly clause to be same in spirit as running in CITGM
+1

I think that if we agree on that, then the entry should be updated to show that test are being run.

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Apr 22, 2022 •
edited
Loading

I would consider if possible run in nightly clause to be same in spirit as running in CITGM
+1

I think that if we agree on that, then the entry should be updated to show that test are being run.

Can you elaborate, please? Should I change https://github.com/nodejs/citgm/blob/fcfc781e72e6ed79ccd8a4e189960111c55f722a/lib/lookup.json#L97-L102 to not skip those tests? btw AIX is not supported AFAIK

RafaelGSS added a commit that referenced this pull request Apr 26, 2022
@RafaelGSS
doc: elevate node-clinic diagnostic tier
d8460de 
PR-URL: #42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS
Copy link
Member Author

Landed in d8460de

@RafaelGSS RafaelGSS closed this Apr 26, 2022
targos pushed a commit that referenced this pull request Apr 28, 2022
@RafaelGSS @targos
doc: elevate node-clinic diagnostic tier
2d76f72 
PR-URL: #42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@RafaelGSS @juanarbol
doc: elevate node-clinic diagnostic tier
2444d5c 
PR-URL: #42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@RafaelGSS @danielleadams
doc: elevate node-clinic diagnostic tier
dd58892 
PR-URL: #42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@RafaelGSS @targos
doc: elevate node-clinic diagnostic tier
5c6c86a 
PR-URL: #42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RafaelGSS @targos
doc: elevate node-clinic diagnostic tier
92d7214 
PR-URL: #42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RafaelGSS @guangwong
doc: elevate node-clinic diagnostic tier
85e37e2 
PR-URL: nodejs/node#42802
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
gireeshpunathil added a commit to gireeshpunathil/node that referenced this pull request Mar 12, 2023
@gireeshpunathil
doc: amend support tier qualifier
d5b971f 
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: nodejs#42802
gireeshpunathil added a commit that referenced this pull request Mar 13, 2023
@gireeshpunathil
doc: amend support tier qualifier
59dd9ca 
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: #42802
PR-URL: #42805
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Mar 13, 2023
@gireeshpunathil @targos
doc: amend support tier qualifier
e5ffba0 
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: #42802
PR-URL: #42805
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@gireeshpunathil @targos
doc: amend support tier qualifier
94882f5 
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: #42802
PR-URL: #42805
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@gireeshpunathil @danielleadams
doc: amend support tier qualifier
0e3077d 
Amend Tier 3 category definition to remove a
tentative clause and introduce a more concrete one.

Refs: #42802
PR-URL: #42805
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-evaluate node-clinic tool tier-list
9 participants
@RafaelGSS @nodejs-github-bot @richardlau @gireeshpunathil @mhdawson @mcollina @jasnell @lpinca @RaisinTen