-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove experimental warning from FormData #42807
feat: remove experimental warning from FormData #42807
Conversation
Review requested:
|
Landed in 5ad47a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed this one and looks good to me! Per @meixg's question in the PR description:
"Is this change need a test? Do we have a way to assert a warning is not output?"
I think we could add a test like this:
// test/parallel/test-fetch-global-non-experimental.mjs
import * as common from '../common/index.mjs';
globalThis.Response;
globalThis.Headers;
globalThis.Request;
globalThis.Response;
globalThis.fetch;
// Only calling the global `fetch` function should result in an
// `ExperimentalWarning` being emitted.
process.on('warning', common.mustCall(0));
I'm happy to open a PR to contribute the test if we think having it is valuable! Thoughts?
fixes: nodejs#42792 PR-URL: nodejs#42807 Fixes: nodejs#42792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
fixes: #42792 PR-URL: #42807 Fixes: #42792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
This depends on #41811 which is not landed in v16.x |
fixes: #42792
Only output experimental warning when calling fetch.
Accessing
FormData
,Headers
,Request
,Response
will not output a warning.Is this change need a test? Do we have a way to assert a warning is not output?