lib: fix AbortSignal.timeout parameter validation #42856

dnalborczyk · 2022-04-25T00:16:07Z

No description provided.

targos · 2022-04-25T05:21:35Z

Sorry, just realized I read the change backwards.

I'm not sure about this (may be a bug in the test). Firefox also allows 0:

aduh95

Can we add a test?

targos · 2022-04-25T08:54:13Z

@aduh95 the test is added in #42855

aduh95 · 2022-04-25T08:57:35Z

@aduh95 the test is added in #42855

I think it makes more sense to land the fix and the test for it in one commit. @dnalborczyk is it ok for you to add this change to the other PR and close this one?

nodejs-github-bot · 2022-10-28T13:03:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47526/

nodejs-github-bot · 2022-10-28T22:47:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47543/

nodejs-github-bot · 2022-10-29T12:09:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47551/

nodejs-github-bot · 2022-10-29T20:20:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47560/

nodejs-github-bot · 2022-10-31T03:58:51Z

Commit Queue failed

- Loading data for nodejs/node/pull/42856 ✔ Done loading data for nodejs/node/pull/42856 ----------------------------------- PR info ------------------------------------ Title lib: fix AbortSignal.timeout parameter validation (#42856) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch dnalborczyk:abort-signal-timeout -> nodejs:main Labels author ready, needs-ci Commits 1 - lib: fix `AbortSignal.timeout` parameter validation Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/42856 Fixes: https://github.com/nodejs/node/pull/42855 Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42856 Fixes: https://github.com/nodejs/node/pull/42855 Reviewed-By: Michaël Zasso Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 25 Apr 2022 00:16:07 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/42856#pullrequestreview-951412614 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/42856#pullrequestreview-951564890 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/42856#pullrequestreview-952570040 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42856#pullrequestreview-1161296570 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-29T20:20:44Z: https://ci.nodejs.org/job/node-test-pull-request/47560/ - Querying data for job/node-test-pull-request/47560/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 42856 From https://github.com/nodejs/node * branch refs/pull/42856/merge -> FETCH_HEAD ✔ Fetched commits as e43ecd5fec30..a8f1d426ab17 -------------------------------------------------------------------------------- [main c7587535eb] lib: fix `AbortSignal.timeout` parameter validation Author: Daniel Nalborczyk Date: Sun Apr 24 20:15:18 2022 -0400 8 files changed, 207 insertions(+), 3 deletions(-) create mode 100644 test/fixtures/wpt/dom/abort/abort-signal-timeout.html create mode 100644 test/fixtures/wpt/dom/abort/crashtests/timeout-close.html create mode 100644 test/fixtures/wpt/dom/abort/reason-constructor.html ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- lib: fix `AbortSignal.timeout` parameter validation

PR-URL: #42856
Fixes: #42855
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

[main bab2062fd3] lib: fix `AbortSignal.timeout` parameter validation
Author: Daniel Nalborczyk dnalborczyk@gmail.com
Date: Sun Apr 24 20:15:18 2022 -0400
8 files changed, 207 insertions(+), 3 deletions(-)
create mode 100644 test/fixtures/wpt/dom/abort/abort-signal-timeout.html
create mode 100644 test/fixtures/wpt/dom/abort/crashtests/timeout-close.html
create mode 100644 test/fixtures/wpt/dom/abort/reason-constructor.html
✖ bab2062fd35087d3c135a6d7c89a921528e08aec
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Pull request URL must reference a comment or discussion. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/3358468679

nodejs-github-bot · 2022-10-31T12:47:40Z

Landed in ffa2e96

PR-URL: #42856 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

PR-URL: nodejs#42856 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

PR-URL: #42856 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 25, 2022

dnalborczyk mentioned this pull request Apr 25, 2022

test: bump dom/abort web-platform-tests #42855

Closed

targos approved these changes Apr 25, 2022

View reviewed changes

aduh95 reviewed Apr 25, 2022

View reviewed changes

benjamingr approved these changes Apr 25, 2022

View reviewed changes

cjihrig approved these changes Apr 26, 2022

View reviewed changes

lib: fix AbortSignal.timeout parameter validation

a8f1d42

aduh95 force-pushed the abort-signal-timeout branch from 3cfe3a7 to a8f1d42 Compare October 28, 2022 12:45

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 28, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022

github-actions bot mentioned this pull request Oct 29, 2022

CI Reliability 2022-10-29 nodejs/reliability#414

Open

15 tasks

This was referenced Oct 30, 2022

CI Reliability 2022-10-30 nodejs/reliability#415

Open

CI Reliability 2022-10-31 nodejs/reliability#416

Open

aduh95 approved these changes Oct 31, 2022

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 31, 2022

Lxxyx approved these changes Oct 31, 2022

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 31, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022

nodejs-github-bot merged commit ffa2e96 into nodejs:main Oct 31, 2022

github-actions bot mentioned this pull request Nov 1, 2022

CI Reliability 2022-11-01 nodejs/reliability#417

Open

17 tasks

RafaelGSS mentioned this pull request Nov 1, 2022

v19.1.0 proposal #45269

Merged

github-actions bot mentioned this pull request Nov 2, 2022

CI Reliability 2022-11-02 nodejs/reliability#418

Open

15 tasks

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: fix AbortSignal.timeout parameter validation #42856

lib: fix AbortSignal.timeout parameter validation #42856

dnalborczyk commented Apr 25, 2022 •

edited by aduh95

Loading

targos commented Apr 25, 2022 •

edited

Loading

aduh95 left a comment

targos commented Apr 25, 2022

aduh95 commented Apr 25, 2022

nodejs-github-bot commented Oct 28, 2022

nodejs-github-bot commented Oct 28, 2022

nodejs-github-bot commented Oct 29, 2022

nodejs-github-bot commented Oct 29, 2022

nodejs-github-bot commented Oct 31, 2022

PR-URL: #42856
Fixes: #42855
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

nodejs-github-bot commented Oct 31, 2022

lib: fix AbortSignal.timeout parameter validation #42856

lib: fix AbortSignal.timeout parameter validation #42856

Conversation

dnalborczyk commented Apr 25, 2022 • edited by aduh95 Loading

targos commented Apr 25, 2022 • edited Loading

aduh95 left a comment

Choose a reason for hiding this comment

targos commented Apr 25, 2022

aduh95 commented Apr 25, 2022

nodejs-github-bot commented Oct 28, 2022

nodejs-github-bot commented Oct 28, 2022

nodejs-github-bot commented Oct 29, 2022

nodejs-github-bot commented Oct 29, 2022

nodejs-github-bot commented Oct 31, 2022

PR-URL: #42856 Fixes: #42855 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

nodejs-github-bot commented Oct 31, 2022

dnalborczyk commented Apr 25, 2022 •

edited by aduh95

Loading

targos commented Apr 25, 2022 •

edited

Loading

PR-URL: #42856
Fixes: #42855
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com