-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: fix CallTracker calls wraps the function causes the original … #42909
Conversation
Should we overwrite the |
should use the original function name or the decorative name, eg |
I think using the exact original name makes more sense, but no strong opinion. |
Am I missing something or the implementation would be much simpler (and less prone to errors like this PR fixes) as a Proxy ? |
Hi @aduh95, can this be merged? |
Landed in 187b99b |
PR-URL: nodejs/node#42909 Fixes: nodejs/node#40484 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
CallTracker calls wraps the function causes the original length to be lost. But many scenarios depend on the length of the function.
func.length
is2
, butcallsfunc.length
is0
.Fixes: #40484