Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update undici to 5.1.1 #42939

Merged
merged 1 commit into from
May 2, 2022
Merged

deps: update undici to 5.1.1 #42939

merged 1 commit into from
May 2, 2022

Conversation

targos
Copy link
Member

@targos targos commented May 2, 2022

Manual update because update-undici.sh needed a small change.

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label May 2, 2022
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43817/

@targos
Copy link
Member Author

targos commented May 2, 2022

@nodejs/undici

mcollina
mcollina approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3bd87e1 into nodejs:master May 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3bd87e1

@targos targos deleted the undici-5-1-1 branch May 2, 2022 12:23
targos added a commit that referenced this pull request May 2, 2022
@targos
deps: update undici to 5.1.1
2a4c826 
PR-URL: #42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request May 2, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2022
Open
33 tasks
tniessen added a commit to tniessen/node that referenced this pull request May 3, 2022
@tniessen
lib,test: enable wasm/webapi/empty-body WPT
ea91bae 
Refs: nodejs#42701
Refs: nodejs/undici#1346
Refs: nodejs#42939
tniessen added a commit to tniessen/node that referenced this pull request May 3, 2022
@tniessen
lib,test: enable wasm/webapi/empty-body WPT
26a6c36 
Refs: nodejs#42701
Refs: nodejs/undici#1346
Refs: nodejs#42939
@tniessen tniessen mentioned this pull request May 3, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 4, 2022
Open
34 tasks
@mcollina mcollina mentioned this pull request May 4, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 5, 2022
Open
32 tasks
nodejs-github-bot pushed a commit that referenced this pull request May 5, 2022
@tniessen
lib,test: enable wasm/webapi/empty-body WPT
55079bb 
Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939

PR-URL: #42960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@tniessen @RafaelGSS
lib,test: enable wasm/webapi/empty-body WPT
c64b8d3 
Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939

PR-URL: #42960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@panther7 panther7 mentioned this pull request May 17, 2022
Closed
juanarbol pushed a commit that referenced this pull request May 31, 2022
@targos @juanarbol
deps: update undici to 5.1.1
0fd9371 
PR-URL: #42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@targos @danielleadams
deps: update undici to 5.1.1
ecd1cff 
PR-URL: #42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos added a commit that referenced this pull request Jul 12, 2022
@targos
deps: update undici to 5.1.1
4e87d34 
PR-URL: #42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos added a commit that referenced this pull request Jul 31, 2022
@targos
deps: update undici to 5.1.1
4d4e00a 
PR-URL: #42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@targos @guangwong
deps: update undici to 5.1.1
d3523a0 
PR-URL: nodejs/node#42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

@aduh95 aduh95 aduh95 approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @mcollina @ronag @aduh95 @VoltrexKeyva