lib: move WebAssembly Web API into separate file #42993
Merged
+69
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
devsnek
approved these changes
May 6, 2022
aduh95
approved these changes
May 6, 2022
tniessen
force-pushed
the
wasm-web-api-move-js-into-different-file
branch
from
899de1c
to
7184d3d
Compare
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
May 6, 2022
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
approved these changes
May 7, 2022
RaisinTen
approved these changes
May 7, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e8e6d45 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
Refs: #42960 (comment) PR-URL: #42993 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
This was referenced May 12, 2022
This was referenced May 13, 2022
|
Backport refs: #42701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves just the JavaScript part of the WebAssembly Web API implementation into a separate file to avoid bloating
pre_execution.js.Refs: #42960 (comment)