build: set ASAN workaround #43085
Closed
build: set ASAN workaround #43085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
Oops, meant to open this in my fork. Shot-in-the-dark testing if the workaround in google/sanitizers#1322 makes any difference. |
gengjiawen
approved these changes
May 14, 2022
|
Looks like this works :) |
I've been rerunning the Test ASan workflow just in case the test is flaky. So far six runs for this PR haven't reproduced #43082 (the first attempt failed with #39655). I'm currently running a seventh. Optimistically marking this as ready for review. |
LiviaMedeiros
approved these changes
May 14, 2022
Trott
approved these changes
May 14, 2022
lpinca
approved these changes
May 14, 2022
gengjiawen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43085 ✔ Done loading data for nodejs/node/pull/43085 ----------------------------------- PR info ------------------------------------ Title build: set ASAN workaround (#43085) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:asan -> nodejs:master Labels meta Commits 1 - build: set ASAN workaround Committers 1 - Richard Lau PR-URL: https://github.com/nodejs/node/pull/43085 Refs: https://github.com/google/sanitizers/issues/1322 Refs: https://github.com/nodejs/node/issues/43082 Reviewed-By: Jiawen Geng Reviewed-By: LiviaMedeiros Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43085 Refs: https://github.com/google/sanitizers/issues/1322 Refs: https://github.com/nodejs/node/issues/43082 Reviewed-By: Jiawen Geng Reviewed-By: LiviaMedeiros Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 13 May 2022 15:20:31 GMT ✔ Approvals: 4 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/43085#pullrequestreview-972969968 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43085#pullrequestreview-973087180 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43085#pullrequestreview-973088632 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43085#pullrequestreview-973094000 ✖ This PR needs to wait 11 more hours to land ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2326053002 |
LiviaMedeiros
added
the
fast-track
|
Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve. |
Trott
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43085 ✔ Done loading data for nodejs/node/pull/43085 ----------------------------------- PR info ------------------------------------ Title build: set ASAN workaround (#43085) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:asan -> nodejs:master Labels meta, fast-track Commits 1 - build: set ASAN workaround Committers 1 - Richard Lau PR-URL: https://github.com/nodejs/node/pull/43085 Refs: https://github.com/google/sanitizers/issues/1322 Refs: https://github.com/nodejs/node/issues/43082 Reviewed-By: Jiawen Geng Reviewed-By: LiviaMedeiros Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43085 Refs: https://github.com/google/sanitizers/issues/1322 Refs: https://github.com/nodejs/node/issues/43082 Reviewed-By: Jiawen Geng Reviewed-By: LiviaMedeiros Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 13 May 2022 15:20:31 GMT ✔ Approvals: 4 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/43085#pullrequestreview-972969968 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43085#pullrequestreview-973087180 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43085#pullrequestreview-973088632 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43085#pullrequestreview-973094000 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2326134851 |
|
Landed in 347000c |
Trott
pushed a commit
that referenced
this pull request
May 15, 2022
PR-URL: #43085 Refs: google/sanitizers#1322 Refs: #43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
@gengjiawen Should we undo 8c800d7? |
Nope, they are different issues #43092 |
This landed on the master branch and then ASan promptly failed, but it was for different reasons, I think. It's now back to its usual timeouts and not the uid-gid problem. So that's good, I think/hope. |
BethGriggs
pushed a commit
that referenced
this pull request
May 16, 2022
PR-URL: #43085 Refs: google/sanitizers#1322 Refs: #43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #43085 Refs: google/sanitizers#1322 Refs: #43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #43085 Refs: google/sanitizers#1322 Refs: #43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43085 Refs: google/sanitizers#1322 Refs: #43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43085 Refs: google/sanitizers#1322 Refs: #43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43085 Refs: google/sanitizers#1322 Refs: nodejs/node#43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: google/sanitizers#1322
Refs: #43082