-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: export constants from fs/promises
#43177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
labels
May 22, 2022
F3n67u
force-pushed
the
fs-constants
branch
3 times, most recently
from
May 22, 2022 15:36
7a98b0b
to
1e353ef
Compare
F3n67u
changed the title
fs: re-export constants from
fs: export constants from May 27, 2022
fs/promises
fs/promises
@LiviaMedeiros I export |
Code looks good to me. Shouldn't documentation be updated accordingly? |
F3n67u
force-pushed
the
fs-constants
branch
2 times, most recently
from
May 27, 2022 14:06
7aa855f
to
2e1197e
Compare
Done. this is the first time to update the Node.js document. please correct me if it is not updated correctly. |
LiviaMedeiros
approved these changes
May 27, 2022
lpinca
approved these changes
May 28, 2022
LiviaMedeiros
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
May 29, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 29, 2022
This comment was marked as outdated.
This comment was marked as outdated.
18 tasks
This was referenced May 31, 2022
19 tasks
aduh95
approved these changes
Jun 2, 2022
19 tasks
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 3, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 3, 2022
Landed in f765693 |
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
PR-URL: nodejs#43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
PR-URL: #43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Nov 23, 2022
PR-URL: nodejs#45556 Refs: nodejs#43177 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr re-export
constants
fromfs/promises
Motivation
see #43140 (comment)
constants
is only export fromfs
, but not export fromfs/promises
.When writing code that uses the promise based fs library via
fs/promises
, if fs constants is used, we have to add another import module which is not convenient:If we re-export
constants
fromfs/promises
, then we could reduce two import to one: