Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use mustSucceed instead of mustCall with assert.ifError #43188

Merged
merged 1 commit into from
May 23, 2022
Merged

test: use mustSucceed instead of mustCall with assert.ifError #43188

merged 1 commit into from
May 23, 2022

Conversation

fossamagna
Copy link
Contributor

Use mustSucceed instead of mustCall + ifError.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 23, 2022
tniessen
tniessen approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44142/

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 23, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit ac4ea62 into nodejs:master May 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ac4ea62

bengl pushed a commit that referenced this pull request May 30, 2022
@fossamagna @bengl
test: use mustSucceed instead of mustCall with assert.ifError
d7ca223 
PR-URL: #43188
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@bengl bengl mentioned this pull request May 31, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@fossamagna @danielleadams
test: use mustSucceed instead of mustCall with assert.ifError
cb1a0b6 
PR-URL: #43188
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@fossamagna @targos
test: use mustSucceed instead of mustCall with assert.ifError
d3607b6 
PR-URL: #43188
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@fossamagna @targos
test: use mustSucceed instead of mustCall with assert.ifError
43e55c6 
PR-URL: #43188
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@fossamagna @guangwong
test: use mustSucceed instead of mustCall with assert.ifError
416f6e4 
PR-URL: nodejs/node#43188
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@himself65 himself65 himself65 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fossamagna @nodejs-github-bot @lpinca @tniessen @himself65 @LiviaMedeiros