src: convey potential exceptions during StreamPipe construction #43240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: nodejs#40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
18 tasks
addaleax
approved these changes
May 30, 2022
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
JungMinu
approved these changes
May 31, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 1, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1496d43 |
RaisinTen
deleted the
src/convey-potential-exceptions-during-StreamPipe-construction
branch
This was referenced Jun 3, 2022
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: nodejs#40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: nodejs/node#40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the V8 calls during the StreamPipe construction to an
overload of
StreamPipe::New(), so that it is possible to indicate ifthere is a pending exception/termination.
Refs: #40425 (comment)
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @addaleax