-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: register StreamBase while registering LibuvStreamWrap #43321
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
RaisinTen:src/register-StreamBase-while-registering-LibuvStreamWrap
Jun 17, 2022
Merged
src: register StreamBase while registering LibuvStreamWrap #43321
nodejs-github-bot
merged 2 commits into
nodejs:main
from
RaisinTen:src/register-StreamBase-while-registering-LibuvStreamWrap
Jun 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jun 5, 2022
This resolves this TODO - https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112. Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
src/register-StreamBase-while-registering-LibuvStreamWrap
branch
from
June 5, 2022 12:41
cd7b929
to
371adec
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung
approved these changes
Jun 10, 2022
RaisinTen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jun 10, 2022
tniessen
reviewed
Jun 10, 2022
Signed-off-by: Darshan Sen <raisinten@gmail.com>
tniessen
approved these changes
Jun 12, 2022
santigimeno
approved these changes
Jun 12, 2022
RaisinTen
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Jun 13, 2022
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jun 13, 2022
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 15, 2022
This comment was marked as outdated.
This comment was marked as outdated.
31 tasks
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 17, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 17, 2022
Landed in ef70718 |
RaisinTen
deleted the
src/register-StreamBase-while-registering-LibuvStreamWrap
branch
June 17, 2022 08:47
This was referenced Jun 18, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This resolves this TODO - https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43321 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
This resolves this TODO - https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43321 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This resolves this TODO - https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43321 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This resolves this TODO - https://github.com/nodejs/node/blob/71071f896aa9696b5d36bb3bec1c7217e7420509/src/stream_wrap.cc#L111-L112. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#43321 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves this TODO -
node/src/stream_wrap.cc
Lines 111 to 112 in 71071f8
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @joyeecheung