Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-worker-http2-stream-terminate flaky on Windows #43425

Conversation

RaisinTen
Copy link
Contributor

The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: #43084
Signed-off-by: Darshan Sen raisinten@gmail.com

The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: nodejs#43084
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2022
@RaisinTen
Copy link
Contributor Author

Hmm, the test still runs and fails on Windows: node-test-binary-windows-js-suites - test.parallel/test-worker-http2-stream-terminate. :/
@richardlau do you know what I'm doing wrong here? I just copied the changes from #41533 and replaced the issue number and the test name.

@RaisinTen RaisinTen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 15, 2022
@RaisinTen
Copy link
Contributor Author

Ah, indeed! Thanks for the clarification @richardlau. :)

@nodejs-github-bot

This comment was marked as outdated.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2022
@nodejs-github-bot nodejs-github-bot merged commit 61c7103 into nodejs:main Jun 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 61c7103

@RaisinTen RaisinTen deleted the test/mark-test-worker-http2-stream-terminate-flaky-on-win branch June 18, 2022 07:08
targos pushed a commit that referenced this pull request Jul 12, 2022
The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: #43084
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43425
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 18, 2022
The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: #43084
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43425
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: #43084
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43425
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
The test is causing a lot of CI failures, so I'd say that we should mark
this test flaky until someone comes up with a proper fix.

Refs: nodejs/node#43084
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#43425
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants