Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update main branch name in GH workflow #43481

Merged
merged 6 commits into from
Jun 23, 2022
Merged

build: update main branch name in GH workflow #43481

merged 6 commits into from
Jun 23, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 19, 2022

Refs: #33864

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@F3n67u F3n67u requested review from RaisinTen and aduh95 June 19, 2022 03:01
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 19, 2022
F3n67u
F3n67u commented Jun 19, 2022
View reviewed changes
.github/workflows/linters.yml Outdated Show resolved Hide resolved
F3n67u and others added 2 commits June 19, 2022 16:04
@F3n67u
Revert "squash: use $default-branch macro rather than hardcoded main"
afc34f3 
This reverts commit 5b036a8.
@F3n67u @aduh95
Update .github/workflows/linters.yml
0d21cf6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@F3n67u @aduh95
Update .github/workflows/linters.yml
6358639 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@F3n67u
Copy link
Member Author

F3n67u commented Jun 19, 2022

@aduh95 I made a mistake, it is github.event.repository.default_branch , not github.repository.default_branch. The format-cpp will not run when pull request if use github.repository.default_branch.

I pushed a new commit to fix this problem: 4f3386a

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2022
RaisinTen
RaisinTen approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@F3n67u
Copy link
Member Author

F3n67u commented Jun 22, 2022

Hey folks. could you help to land this pr please？the format-cpp check is not run for all pr into main, I am worried about it would introduce some cpp format problem to main.

juanarbol
juanarbol approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaisinTen RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6f924ac into nodejs:main Jun 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6f924ac

@F3n67u F3n67u deleted the main-workflow branch June 23, 2022 05:09
@F3n67u
Copy link
Member Author

F3n67u commented Jun 23, 2022

Thank you.

F3n67u added a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@F3n67u
build: update main branch name in GH workflow
e6ebef3 
PR-URL: nodejs#43481
Refs: nodejs#33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
build: update main branch name in GH workflow
919c5ee 
PR-URL: #43481
Refs: #33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u @targos
build: update main branch name in GH workflow
38b24b0 
PR-URL: #43481
Refs: #33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
build: update main branch name in GH workflow
600505e 
PR-URL: #43481
Refs: #33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
build: update main branch name in GH workflow
91e0a45 
PR-URL: nodejs/node#43481
Refs: nodejs/node#33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@bnb bnb bnb approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@F3n67u @nodejs-github-bot @bnb @lpinca @targos @aduh95 @juanarbol @RaisinTen