Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-worker-http2-stream-terminate flaky on all platforms #43620

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 29, 2022

@F3n67u F3n67u marked this pull request as ready for review June 29, 2022 14:42
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 29, 2022
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

@F3n67u F3n67u added fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. labels Jun 29, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 29, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @F3n67u. Please 👍 to approve.

Copy link
Contributor

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "test: mark test-worker-http2-stream-terminate flaky on all platforms" be a more accurate commit message?

@F3n67u F3n67u changed the title test: mark test-worker-http2-stream-terminate on all platforms test: mark test-worker-http2-stream-terminate flaky on all platforms Jun 29, 2022
@F3n67u F3n67u force-pushed the flaky-test-worker-http2-stream-terminate branch from 91ca85d to 9a21438 Compare June 30, 2022 00:45
@F3n67u
Copy link
Member Author

F3n67u commented Jun 30, 2022

Would "test: mark test-worker-http2-stream-terminate flaky on all platforms" be a more accurate commit message?

good catch. fixed.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 30, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@F3n67u
Copy link
Member Author

F3n67u commented Jul 1, 2022

Hi. collaborators! could you help to resume ci?

@nodejs-github-bot

This comment was marked as outdated.

@F3n67u
Copy link
Member Author

F3n67u commented Jul 1, 2022

Please help to resume ci again. our old flaky friend test-stream-finished failed again.😂

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45034/

@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2bd940c into nodejs:main Jul 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 2bd940c

@F3n67u F3n67u deleted the flaky-test-worker-http2-stream-terminate branch July 1, 2022 23:50
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43620
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43620
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43620
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43620
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants