test: fix coverity warning in test

[mhdawson]

Fix uninitialized pointer field warning in test

Signed-off-by: Michael Dawson mdawson@devrus.com

[mhdawson]

Warning from coverity

class TestSocketServerDelegate : public SocketServerDelegate {
303 public:
304  explicit TestSocketServerDelegate(
305      ServerHolder* server,
306      const std::vector<std::string>& target_ids)
307      : harness_(server),
308        targets_(target_ids),
   	
CID 189784 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member server_ is not initialized in this constructor nor in any functions that it calls.
309        session_id_(0) {}
310
311  ~TestSocketServerDelegate() override {
312    harness_->Done();
313  }

[mhdawson]

I swear I ran the make lint-cpp and it passed ...

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/43631
✔  Done loading data for nodejs/node/pull/43631
----------------------------------- PR info ------------------------------------
Title      test: fix coverity warning in test (#43631)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:coverity-24 -> nodejs:main
Labels     test, inspector, needs-ci
Commits    2
 - test: fix coverity warning in test
 - fixup: make linter happy
Committers 1
 - Michael Dawson 
PR-URL: https://github.com/nodejs/node/pull/43631
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43631
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 30 Jun 2022 14:50:05 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43631#pullrequestreview-1025016627
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43631#pullrequestreview-1025026086
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43631#pullrequestreview-1025240997
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43631#pullrequestreview-1027331010
   ✖  Last GitHub CI failed
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2609315402

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45088/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/43631
✔  Done loading data for nodejs/node/pull/43631
----------------------------------- PR info ------------------------------------
Title      test: fix coverity warning in test (#43631)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:coverity-24 -> nodejs:main
Labels     test, inspector, needs-ci, commit-queue-rebase
Commits    2
 - test: fix coverity warning in test
 - fixup: make linter happy
Committers 1
 - Michael Dawson 
PR-URL: https://github.com/nodejs/node/pull/43631
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43631
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 30 Jun 2022 14:50:05 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43631#pullrequestreview-1025016627
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43631#pullrequestreview-1025026086
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43631#pullrequestreview-1025240997
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43631#pullrequestreview-1027331010
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-07-04T18:50:29Z: https://ci.nodejs.org/job/node-test-pull-request/45088/
- Querying data for job/node-test-pull-request/45088/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 43631
From https://github.com/nodejs/node
 * branch                  refs/pull/43631/merge -> FETCH_HEAD
✔  Fetched commits as adef64ce633f..c7f551905150
--------------------------------------------------------------------------------
[main 70dea84184] test: fix coverity warning in test
 Author: Michael Dawson 
 Date: Thu Jun 30 10:41:36 2022 -0400
 1 file changed, 1 insertion(+)
[main 41229d5f33] fixup: make linter happy
 Author: Michael Dawson 
 Date: Thu Jun 30 12:52:19 2022 -0400
 1 file changed, 2 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: fix coverity warning in test
Fix uninitialized pointer field warning in test
Signed-off-by: Michael Dawson mdawson@devrus.com
PR-URL: #43631

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com
[detached HEAD 456fc2f2ec] test: fix coverity warning in test

Author: Michael Dawson mdawson@devrus.com

Date: Thu Jun 30 10:41:36 2022 -0400

1 file changed, 1 insertion(+)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup: make linter happy
Signed-off-by: Michael Dawson mdawson@devrus.com
PR-URL: #43631

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com
[detached HEAD 532f4090f4] fixup: make linter happy

Author: Michael Dawson mdawson@devrus.com

Date: Thu Jun 30 12:52:19 2022 -0400

1 file changed, 2 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.
✔  456fc2f2ec3c31f8f28bbe0bdacfd4bfa7ebba49

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  5:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

✖  532f4090f4a9fd27ce168c6f128288870b5e4919

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  3:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Invalid subsystem: "fixup"                subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/2638392091

[mhdawson]

Landed in 98ade2d