util: add `AggregateError.prototype.errors` to inspect output #43646

LiviaMedeiros · 2022-07-01T19:23:53Z

Old:

> (()=>{throw new AggregateError([new TypeError('blep'), new RangeError('blop')],'gwak')})()
Uncaught AggregateError: gwak
    at REPL1:1:13

New:

> (()=>{throw new AggregateError([new TypeError('blep'), new RangeError('blop')],'gwak')})()
Uncaught AggregateError: gwak
    at REPL1:1:13 {
  [errors]: [
    TypeError: blep
        at REPL1:1:33
        at REPL1:1:89
        at Script.runInThisContext (node:vm:130:12)
        at REPLServer.defaultEval (node:repl:572:29)
        at bound (node:domain:426:15)
        at REPLServer.runBound [as eval] (node:domain:437:12)
        at REPLServer.onLine (node:repl:902:10)
        at REPLServer.emit (node:events:549:35)
        at REPLServer.emit (node:domain:482:12)
        at [_onLine] [as _onLine] (node:internal/readline/interface:425:12),
    RangeError: blop
        at REPL1:1:56
        at REPL1:1:89
        at Script.runInThisContext (node:vm:130:12)
        at REPLServer.defaultEval (node:repl:572:29)
        at bound (node:domain:426:15)
        at REPLServer.runBound [as eval] (node:domain:437:12)
        at REPLServer.onLine (node:repl:902:10)
        at REPLServer.emit (node:events:549:35)
        at REPLServer.emit (node:domain:482:12)
        at [_onLine] [as _onLine] (node:internal/readline/interface:425:12)
  ]
}

lib/internal/errors.js

BridgeAR

Code LGTM.

Please change the module to util.

lib/internal/util/inspect.js

nodejs-github-bot · 2022-07-08T15:25:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45182/

nodejs-github-bot · 2022-07-09T13:07:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45219/

nodejs-github-bot · 2022-07-09T16:01:04Z

Landed in 653cfff

PR-URL: #43646 Fixes: #43645 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs/node#43646

* chore: bump node in DEPS to v16.17.0 * chore: fixup asar patch * lib: use null-prototype objects for property descriptors nodejs/node#43270 * src: make SecureContext fields private nodejs/node#43173 * crypto: remove Node.js-specific webcrypto extensions nodejs/node#43310 * test: refactor to top-level await nodejs/node#43500 * deps: cherry-pick two libuv fixes nodejs/node#43950 * src: slim down env-inl.h nodejs/node#43745 * util: add AggregateError.prototype.errors to inspect output nodejs/node#43646 * esm: improve performance & tidy tests nodejs/node#43784 * src: NodeArrayBufferAllocator delegates to v8's allocator nodejs/node#43594 * chore: update patch indices * chore: update filenames * src: refactor IsSupportedAuthenticatedMode nodejs/node#42368 * src: add --openssl-legacy-provider option nodejs/node#40478 * lib,src: add source map support for global eval nodejs/node#43428 * trace_events: trace net connect event nodejs/node#43903 * deps: update ICU to 71.1 nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 * lib: give names to promisified exists() and question() nodejs/node#43218 * crypto: add CFRG curves to Web Crypto API nodejs/node#42507 * src: fix memory leak for v8.serialize nodejs/node#42695 This test does not work for Electron as they do not use V8's ArrayBufferAllocator. * buffer: fix atob input validation nodejs/node#42539 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

PR-URL: nodejs/node#43646 Fixes: nodejs/node#43645 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

* chore: bump node in DEPS to v16.17.0 * chore: fixup asar patch * lib: use null-prototype objects for property descriptors nodejs/node#43270 * src: make SecureContext fields private nodejs/node#43173 * crypto: remove Node.js-specific webcrypto extensions nodejs/node#43310 * test: refactor to top-level await nodejs/node#43500 * deps: cherry-pick two libuv fixes nodejs/node#43950 * src: slim down env-inl.h nodejs/node#43745 * util: add AggregateError.prototype.errors to inspect output nodejs/node#43646 * esm: improve performance & tidy tests nodejs/node#43784 * src: NodeArrayBufferAllocator delegates to v8's allocator nodejs/node#43594 * chore: update patch indices * chore: update filenames * src: refactor IsSupportedAuthenticatedMode nodejs/node#42368 * src: add --openssl-legacy-provider option nodejs/node#40478 * lib,src: add source map support for global eval nodejs/node#43428 * trace_events: trace net connect event nodejs/node#43903 * deps: update ICU to 71.1 nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 * lib: give names to promisified exists() and question() nodejs/node#43218 * crypto: add CFRG curves to Web Crypto API nodejs/node#42507 * src: fix memory leak for v8.serialize nodejs/node#42695 This test does not work for Electron as they do not use V8's ArrayBufferAllocator. * buffer: fix atob input validation nodejs/node#42539 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jul 1, 2022

aduh95 reviewed Jul 4, 2022

View reviewed changes

lib/internal/errors.js Outdated Show resolved Hide resolved

devsnek reviewed Jul 4, 2022

View reviewed changes

lib/internal/errors.js Outdated Show resolved Hide resolved

LiviaMedeiros marked this pull request as ready for review July 5, 2022 11:00

LiviaMedeiros changed the title ~~errors: add custom inspector for AggregateError~~ errors: add AggregateError.prototype.errors to inspect output Jul 5, 2022

BridgeAR approved these changes Jul 5, 2022

View reviewed changes

util: add AggregateError.prototype.errors to inspect output

36b9381

LiviaMedeiros force-pushed the inspect-agriculture-error branch from c5ffb07 to 36b9381 Compare July 5, 2022 12:50

LiviaMedeiros changed the title ~~errors: add AggregateError.prototype.errors to inspect output~~ util: add AggregateError.prototype.errors to inspect output Jul 5, 2022

aduh95 reviewed Jul 5, 2022

View reviewed changes

lib/internal/util/inspect.js Outdated Show resolved Hide resolved

squash: make .errors check more strict

9af23e0

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2022

This comment was marked as outdated.

Sign in to view

aduh95 approved these changes Jul 8, 2022

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2022

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Jul 9, 2022

CI Reliability 2022-07-09 nodejs/reliability#319

Open

21 tasks

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 9, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2022

nodejs-github-bot merged commit 653cfff into nodejs:main Jul 9, 2022

github-actions bot mentioned this pull request Jul 10, 2022

CI Reliability 2022-07-10 nodejs/reliability#320

Open

20 tasks

targos pushed a commit that referenced this pull request Jul 12, 2022

util: add AggregateError.prototype.errors to inspect output

5a5c4be

PR-URL: #43646 Fixes: #43645 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Jul 12, 2022

v18.6.0 release proposal #43789

Merged

F3n67u mentioned this pull request Jul 12, 2022

Investigate flaky pummel/test-http-upload-timeout #43800

Closed

targos pushed a commit that referenced this pull request Jul 31, 2022

util: add AggregateError.prototype.errors to inspect output

5edfccf

PR-URL: #43646 Fixes: #43645 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

codebytere added a commit to electron/electron that referenced this pull request Aug 22, 2022

util: add AggregateError.prototype.errors to inspect output

c137633

nodejs/node#43646

codebytere added a commit to electron/electron that referenced this pull request Aug 23, 2022

util: add AggregateError.prototype.errors to inspect output

3033afe

nodejs/node#43646

codebytere added a commit to electron/electron that referenced this pull request Aug 24, 2022

util: add AggregateError.prototype.errors to inspect output

717ed36

nodejs/node#43646

codebytere added a commit to electron/electron that referenced this pull request Aug 25, 2022

util: add AggregateError.prototype.errors to inspect output

9afd11e

nodejs/node#43646

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: add `AggregateError.prototype.errors` to inspect output #43646

util: add `AggregateError.prototype.errors` to inspect output #43646

LiviaMedeiros commented Jul 1, 2022 •

edited

Loading

BridgeAR left a comment

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jul 8, 2022

nodejs-github-bot commented Jul 9, 2022

nodejs-github-bot commented Jul 9, 2022

util: add AggregateError.prototype.errors to inspect output #43646

util: add AggregateError.prototype.errors to inspect output #43646

Conversation

LiviaMedeiros commented Jul 1, 2022 • edited Loading

BridgeAR left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jul 8, 2022

nodejs-github-bot commented Jul 9, 2022

nodejs-github-bot commented Jul 9, 2022

util: add `AggregateError.prototype.errors` to inspect output #43646

util: add `AggregateError.prototype.errors` to inspect output #43646

LiviaMedeiros commented Jul 1, 2022 •

edited

Loading