Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: remove unicode support todo for perf implications #43762

Merged
merged 2 commits into from
Jul 24, 2022
Merged

util: remove unicode support todo for perf implications #43762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81b4926
util: remove unicode support todo for perf implications
Anemy Jul 10, 2022
b8f3e6b
add comment on unicode character performance implications
Anemy Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1530,8 +1530,9 @@ function formatPrimitive(fn, value, ctx) {
trailer = `... ${remaining} more character${remaining > 1 ? 's' : ''}`;
}
if (ctx.compact !== true &&
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
// function.
BridgeAR marked this conversation as resolved.
Show resolved Hide resolved
// We do not support handling unicode characters width with
// the readline getStringWidth function as there are
// performance implications.
value.length > kMinLineLength &&
value.length > ctx.breakLength - ctx.indentationLvl - 4) {
return value
Expand Down