Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in file name #43764

Merged
merged 1 commit into from
Jul 11, 2022
Merged

test: fix typo in file name #43764

merged 1 commit into from
Jul 11, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 10, 2022

desctibe -> describe

@aduh95
test: fix typo in file name
b3ac136 
`desctibe` -> `describe`
@aduh95 aduh95 added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. test_runner Issues and PRs related to the test runner subsystem. labels Jul 10, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 10, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Jul 10, 2022
MoLow
MoLow reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops :) thanks for fixing

@marsonya marsonya added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 11, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43764
✔  Done loading data for nodejs/node/pull/43764
----------------------------------- PR info ------------------------------------
Title      test: fix typo in file name (#43764)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-typo-test-runner -> nodejs:main
Labels     test, fast-track, author ready, test_runner
Commits    1
 - test: fix typo in file name
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/43764
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Darshan Sen 
Reviewed-By: Akhil Marsonya 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43764
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Darshan Sen 
Reviewed-By: Akhil Marsonya 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 10 Jul 2022 20:43:19 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033710605
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033720542
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033783728
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43764#pullrequestreview-1033830849
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2647593136

@aduh95 aduh95 merged commit a276bd8 into nodejs:main Jul 11, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Jul 11, 2022

Landed in a276bd8

@aduh95 aduh95 deleted the fix-typo-test-runner branch July 11, 2022 08:27
@richardlau richardlau mentioned this pull request Jul 11, 2022
Closed
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95 @targos
test: fix typo in file name
b164848 
`desctibe` -> `describe`

PR-URL: #43764
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
test: fix typo in file name
95a823d 
`desctibe` -> `describe`

PR-URL: #43764
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
test: fix typo in file name
1b4a7f9 
`desctibe` -> `describe`

PR-URL: nodejs/node#43764
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow left review comments

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@F3n67u F3n67u F3n67u approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. test_runner Issues and PRs related to the test runner subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aduh95 @nodejs-github-bot @Trott @lpinca @cjihrig @MoLow @F3n67u @marsonya @RaisinTen @targos