v18.6.0 release proposal

.github/workflows/build-tarball.yml

@@ -12,7 +12,6 @@ on:
       - '!.github/workflows/build-tarball.yml'
   push:
     branches:
-      - master
       - main
       - v[0-9]+.x-staging
       - v[0-9]+.x

.github/workflows/build-windows.yml

@@ -9,7 +9,6 @@ on:
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
-      - master
       - main
       - canary
       - v[0-9]+.x-staging

.github/workflows/coverage-linux.yml

@@ -11,7 +11,8 @@ on:
       - .github/**
       - '!.github/workflows/coverage-linux.yml'
   push:
-    branches: [master, main]
+    branches:
+      - main
     paths-ignore:
       - '**.md'
       - benchmark/**

.github/workflows/coverage-windows.yml

@@ -12,7 +12,8 @@ on:
       - .github/**
       - '!.github/workflows/coverage-windows.yml'
   push:
-    branches: [master, main]
+    branches:
+      - main
     paths-ignore:
       - '**.md'
       - benchmark/**

.github/workflows/doc.yml

@@ -5,7 +5,6 @@ on:
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
-      - master
       - main
       - v[0-9]+.x-staging
       - v[0-9]+.x

.github/workflows/linters.yml

@@ -5,7 +5,6 @@ on:
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
-      - master
       - main
       - v[0-9]+.x-staging
       - v[0-9]+.x
@@ -50,7 +49,7 @@ jobs:
       - name: Lint C/C++ files
         run: make lint-cpp
   format-cpp:
-    if: ${{ github.event.pull_request.draft == false && github.base_ref == 'master' }}
+    if: ${{ github.event.pull_request && github.event.pull_request.draft == false && github.base_ref == github.event.repository.default_branch }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

.github/workflows/notify-force-push.yml

@@ -1,7 +1,6 @@
 on:
   push:
     branches:
-      - master
       - main
 
 name: Notify on Force Push

.github/workflows/test-asan.yml

@@ -12,7 +12,6 @@ on:
       - '!.github/workflows/test-asan.yml'
   push:
     branches:
-      - master
       - main
       - canary
       - v[0-9]+.x-staging

.github/workflows/test-internet.yml

@@ -10,7 +10,6 @@ on:
     paths: [test/internet/**]
   push:
     branches:
-      - master
       - main
       - canary
       - v[0-9]+.x-staging

.github/workflows/test-linux.yml

@@ -9,7 +9,6 @@ on:
     types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
-      - master
       - main
       - canary
       - v[0-9]+.x-staging

.github/workflows/test-macos.yml

@@ -12,7 +12,6 @@ on:
       - '!.github/workflows/test-macos.yml'
   push:
     branches:
-      - master
       - main
       - canary
       - v[0-9]+.x-staging

.gitignore

@@ -19,6 +19,7 @@
 !.github
 !.gitignore
 !.gitkeep
+!.gitpod.yml
 !.mailmap
 !.nycrc
 !.yamllint.yaml

.gitpod.yml

@@ -0,0 +1,9 @@
+# Ref: https://github.com/gitpod-io/gitpod/issues/6283#issuecomment-1001043454
+tasks:
+  - init: ./configure && timeout 50m make -j16 || true
+
+# Ref: https://www.gitpod.io/docs/prebuilds#github-specific-configuration
+github:
+  prebuilds:
+    # add a "Review in Gitpod" button as a comment to pull requests (defaults to true)
+    addComment: false

.mailmap

@@ -380,6 +380,7 @@ Noah Rose Ledesma <noahroseledesma@seattleacademy.org>
 npm team <ops+robot@npmjs.com>
 npm team <ops+robot@npmjs.com> <npm CLI robot>
 npm team <ops+robot@npmjs.com> <npm team>
+npm team <ops+robot@npmjs.com> <npm-cli+bot@github.com>
 Oliver Chang <ochang@chromium.org>
 Oluwaseun Omoyajowo <omoyajowo2015@gmail.com>
 OneNail <OneNail@yeah.net> <onenail@yeah.net>
@@ -450,6 +451,7 @@ Saúl Ibarra Corretgé <s@saghul.net> <saghul@gmail.com>
 Scott Blomquist <github@scott.blomqui.st> <sblom@microsoft.com>
 Segu Riluvan <rilwan22@hotmail.com> <riluvan@gmail.com>
 Sergey Kryzhanovsky <skryzhanovsky@gmail.com> <another@dhcp199-223-red.yandex.net>
+Sergey Petushkov <petushkov.sergey@gmail.com> <sergey.petushkov@protonmail.com>
 Sergey Zelenov <mail@zelenov.su> <sergey.zelenov@getyourguide.com>
 Shannen Saez <shannenlaptop@gmail.com>
 Shaopeng Zhang <szhang351@bloomberg.net>
@@ -489,6 +491,7 @@ Tarun Batra <tarun.batra00@gmail.com>
 Taylor Woll <taylor.woll@microsoft.com> <tawoll@ntdev.microsoft.com>
 Ted Young <ted@radicaldesigns.org>
 Teppei Sato <teppeis@gmail.com>
+theanarkh <theratliter@gmail.com> <2923878201@qq.com>
 Theotime Poisseau <theotime.poisseau@gmail.com>
 Thomas Hunter II <me@thomashunter.name> <tom@intrinsic.com>
 Thomas Lee <thomas.lee@shinetech.com> <tom@tom-debian.sensis.com.au>

AUTHORS

@@ -3441,7 +3441,7 @@ Damjan Cvetko <damjan.cvetko@gmail.com>
 Randall Leeds <randall@bleeds.info>
 Khoo Hao Yit <40757009+KhooHaoYit@users.noreply.github.com>
 Aroyan <43630681+aroyan@users.noreply.github.com>
-theanarkh <2923878201@qq.com>
+theanarkh <theratliter@gmail.com>
 Vladimir Morozov <vmorozov@microsoft.com>
 Anupama Codippily <47591753+AnupamaCodippily@users.noreply.github.com>
 Greg Poole <gpoole@users.noreply.github.com>
@@ -3464,5 +3464,22 @@ rikapo <rikaporori@gmail.com>
 Meek Simbule <55823259+meekdenzo@users.noreply.github.com>
 Michael Ficarra <github@michael.ficarra.me>
 hiroki osame <hiroki.osame@gmail.com>
+Eugene Chapko <eugene.chapko@gmail.com>
+Sergey Petushkov <petushkov.sergey@gmail.com>
+Caleb Everett <everett.caleb@gmail.com>
+JialuZhang-intel <jialu.zhang@intel.com>
+Moshe Atlow <moshe@atlow.co.il>
+rubikscraft <contact@rubikscraft.nl>
+James Scott-Brown <james@jamesscottbrown.com>
+supriyo-biswas <supriyo.biswas.96@gmail.com>
+Giacomo Gregoletto <greguz@users.noreply.github.com>
+italo jose <italo.i@live.com>
+Kazuma Ohashi <tikuwaaaaaaaa@gmail.com>
+Douglas Wilson <67512+dougwilson@users.noreply.github.com>
+0xSanyam <108138884+0xSanyam@users.noreply.github.com>
+Alena Khineika <alena.khineika@gmail.com>
+Basit <1305718+mabaasit@users.noreply.github.com>
+Kid <44045911+kidonng@users.noreply.github.com>
+Jeremy Rose <japthorp@slack-corp.com>
 
 # Generated by tools/update-authors.mjs

BUILDING.md

@@ -567,9 +567,9 @@ to run it again before invoking `make -j4`.
 
 * [Python 3.10](https://www.microsoft.com/en-us/p/python-310/9pjpw5ldxlz5)
 * The "Desktop development with C++" workload from
-  [Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) or
+  [Visual Studio 2019](https://visualstudio.microsoft.com/vs/older-downloads/#visual-studio-2019-and-other-products) or
   the "C++ build tools" workload from the
-  [Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019),
+  [Build Tools](https://aka.ms/vs/16/release/vs_buildtools.exe),
   with the default optional components
 * Basic Unix tools required for some tests,
   [Git for Windows](https://git-scm.com/download/win) includes Git Bash

CHANGELOG.md

@@ -35,7 +35,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V18.md#18.5.0">18.5.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V18.md#18.6.0">18.6.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V18.md#18.5.0">18.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.4.0">18.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.3.0">18.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V18.md#18.2.0">18.2.0</a><br/>

Makefile

@@ -1096,7 +1096,7 @@ endif
 		$(MACOSOUTDIR)/dist/npm/usr/local/lib/node_modules
 	unlink $(MACOSOUTDIR)/dist/node/usr/local/bin/npm
 	unlink $(MACOSOUTDIR)/dist/node/usr/local/bin/npx
-	$(NODE) tools/license2rtf.js < LICENSE > \
+	$(NODE) tools/license2rtf.mjs < LICENSE > \
 		$(MACOSOUTDIR)/installer/productbuild/Resources/license.rtf
 	cp doc/osx_installer_logo.png $(MACOSOUTDIR)/installer/productbuild/Resources
 	pkgbuild --version $(FULLVERSION) \
@@ -1429,8 +1429,8 @@ CLANG_FORMAT_START ?= HEAD
 #  $ make format-cpp
 # To format HEAD~1...HEAD (latest commit):
 #  $ CLANG_FORMAT_START=`git rev-parse HEAD~1` make format-cpp
-# To format diff between master and current branch head (master...HEAD):
-#  $ CLANG_FORMAT_START=master make format-cpp
+# To format diff between main and current branch head (main...HEAD):
+#  $ CLANG_FORMAT_START=main make format-cpp
 format-cpp: ## Format C++ diff from $CLANG_FORMAT_START to current changes
 ifneq ("","$(wildcard tools/clang-format/node_modules/)")
 	$(info Formatting C++ diff from $(CLANG_FORMAT_START)..)
@@ -1440,7 +1440,7 @@ ifneq ("","$(wildcard tools/clang-format/node_modules/)")
 		$(CLANG_FORMAT_START) -- \
 		$(LINT_CPP_FILES)
 else
-	$(info clang-format is not installed.)
+	$(info Required tooling for C++ code formatting is not installed.)
 	$(info To install (requires internet access) run: $$ make format-cpp-build)
 endif
 

README.md

@@ -170,6 +170,8 @@ For information about the governance of the Node.js project, see
   **Danielle Adams** <<adamzdanielle@gmail.com>> (she/her)
 * [fhinkel](https://github.com/fhinkel) -
   **Franziska Hinkelmann** <<franziska.hinkelmann@gmail.com>> (she/her)
+* [GeoffreyBooth](https://github.com/geoffreybooth) -
+  **Geoffrey Booth** <<webadmin@geoffreybooth.com>> (he/him)
 * [gireeshpunathil](https://github.com/gireeshpunathil) -
   **Gireesh Punathil** <<gpunathi@in.ibm.com>> (he/him)
 * [jasnell](https://github.com/jasnell) -
@@ -180,8 +182,6 @@ For information about the governance of the Node.js project, see
   **Matteo Collina** <<matteo.collina@gmail.com>> (he/him)
 * [mhdawson](https://github.com/mhdawson) -
   **Michael Dawson** <<midawson@redhat.com>> (he/him)
-* [MylesBorins](https://github.com/MylesBorins) -
-  **Myles Borins** <<myles.borins@gmail.com>> (he/him)
 * [RaisinTen](https://github.com/RaisinTen) -
   **Darshan Sen** <<raisinten@gmail.com>> (he/him)
 * [richardlau](https://github.com/richardlau) -
@@ -229,6 +229,8 @@ For information about the governance of the Node.js project, see
   **Mary Marchini** <<oss@mmarchini.me>> (she/her)
 * [mscdex](https://github.com/mscdex) -
   **Brian White** <<mscdex@mscdex.net>>
+* [MylesBorins](https://github.com/MylesBorins) -
+  **Myles Borins** <<myles.borins@gmail.com>> (he/him)
 * [nebrius](https://github.com/nebrius) -
   **Bryan Hughes** <<bryan@nebri.us>>
 * [ofrobots](https://github.com/ofrobots) -
@@ -646,6 +648,8 @@ maintaining the Node.js project.
 
 * [Ayase-252](https://github.com/Ayase-252) -
   **Qingyu Deng** <<i@ayase-lab.com>>
+* [daeyeon](https://github.com/daeyeon) -
+  **Daeyeon Jeong** <<daeyeon.dev@gmail.com>> (he/him)
 * [F3n67u](https://github.com/F3n67u) -
   **Feng Yu** <<F3n67u@outlook.com>> (he/him)
 * [himadriganguly](https://github.com/himadriganguly) -

benchmark/common.js

@@ -289,7 +289,15 @@ function formatResult(data) {
 function sendResult(data) {
   if (process.send) {
     // If forked, report by process send
-    process.send(data);
+    process.send(data, () => {
+      if (Object.hasOwn(process.env, 'NODE_RUN_BENCHMARK_FN')) {
+        // If, for any reason, the process is unable to self close within
+        // a second after completing, forcefully close it.
+        setTimeout(() => {
+          process.exit(0);
+        }, 5000).unref();
+      }
+    });
   } else {
     // Otherwise report by stdout
     process.stdout.write(formatResult(data));

benchmark/es/eval.js

@@ -0,0 +1,46 @@
+'use strict';
+
+const common = require('../common.js');
+
+const bench = common.createBenchmark(main, {
+  method: ['without-sourcemap', 'sourcemap'],
+  n: [1e6],
+});
+
+const sourceWithoutSourceMap = `
+'use strict';
+(function() {
+  let a = 1;
+  for (let i = 0; i < 1000; i++) {
+    a++;
+  }
+  return a;
+})();
+`;
+const sourceWithSourceMap = `
+${sourceWithoutSourceMap}
+//# sourceMappingURL=https://ci.nodejs.org/405
+`;
+
+function evalN(n, source) {
+  bench.start();
+  for (let i = 0; i < n; i++) {
+    eval(source);
+  }
+  bench.end(n);
+}
+
+function main({ n, method }) {
+  switch (method) {
+    case 'without-sourcemap':
+      process.setSourceMapsEnabled(false);
+      evalN(n, sourceWithoutSourceMap);
+      break;
+    case 'sourcemap':
+      process.setSourceMapsEnabled(true);
+      evalN(n, sourceWithSourceMap);
+      break;
+    default:
+      throw new Error(`Unexpected method "${method}"`);
+  }
+}

benchmark/tls/secure-pair.js

@@ -25,6 +25,7 @@ function main({ dur, size, securing }) {
     isServer: true,
     requestCert: true,
     rejectUnauthorized: true,
+    maxVersion: 'TLSv1.2',
   };
 
   const server = net.createServer(onRedirectConnection);
@@ -38,6 +39,7 @@ function main({ dur, size, securing }) {
         cert: options.cert,
         isServer: false,
         rejectUnauthorized: false,
+        maxVersion: options.maxVersion,
       };
       const network = securing === 'clear' ? net : tls;
       const conn = network.connect(clientOptions, () => {

benchmark/tls/throughput-c2s.js

@@ -33,7 +33,8 @@ function main({ dur, type, size }) {
     key: fixtures.readKey('rsa_private.pem'),
     cert: fixtures.readKey('rsa_cert.crt'),
     ca: fixtures.readKey('rsa_ca.crt'),
-    ciphers: 'AES256-GCM-SHA384'
+    ciphers: 'AES256-GCM-SHA384',
+    maxVersion: 'TLSv1.2',
   };
 
   const server = tls.createServer(options, onConnection);

benchmark/tls/throughput-s2c.js

@@ -40,7 +40,8 @@ function main({ dur, type, sendchunklen, recvbuflen, recvbufgenfn }) {
     key: fixtures.readKey('rsa_private.pem'),
     cert: fixtures.readKey('rsa_cert.crt'),
     ca: fixtures.readKey('rsa_ca.crt'),
-    ciphers: 'AES256-GCM-SHA384'
+    ciphers: 'AES256-GCM-SHA384',
+    maxVersion: 'TLSv1.2',
   };
 
   let socketOpts;

benchmark/tls/tls-connect.js

@@ -21,7 +21,8 @@ function main(conf) {
     key: fixtures.readKey('rsa_private.pem'),
     cert: fixtures.readKey('rsa_cert.crt'),
     ca: fixtures.readKey('rsa_ca.crt'),
-    ciphers: 'AES256-GCM-SHA384'
+    ciphers: 'AES256-GCM-SHA384',
+    maxVersion: 'TLSv1.2',
   };
 
   const server = tls.createServer(options, onConnection);

deps/corepack/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## [0.12.0](https://github.com/nodejs/corepack/compare/v0.11.2...v0.12.0) (2022-07-09)
+
+
+### Features
+
+* add support for hash checking ([#133](https://github.com/nodejs/corepack/issues/133)) ([6a480a7](https://github.com/nodejs/corepack/commit/6a480a72c2e9fc6725f2ab6dfaf4c52e4d3d2ade))
+* add support for tags and ranges in `prepare` command ([#136](https://github.com/nodejs/corepack/issues/136)) ([29da06c](https://github.com/nodejs/corepack/commit/29da06c515e917829e5ffbedb34284a6597e9d56))
+* update package manager versions ([#129](https://github.com/nodejs/corepack/issues/129)) ([2470f58](https://github.com/nodejs/corepack/commit/2470f58b74491a1301221df643c55be5adf1d349))
+* update package manager versions ([#139](https://github.com/nodejs/corepack/issues/139)) ([cd0dcad](https://github.com/nodejs/corepack/commit/cd0dcade85621199048d7ca30dfc3efce11e1f37))
+
+
+### Bug Fixes
+
+* streamline the cache exploration ([#135](https://github.com/nodejs/corepack/issues/135)) ([185da44](https://github.com/nodejs/corepack/commit/185da44078fd1ca34aec2e4e6f8a52ecffcf3c11))
+
 ## [0.11.2](https://github.com/nodejs/corepack/compare/v0.11.1...v0.11.2) (2022-06-13)
 
 ### Bug Fixes