-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: shim for invoking node w/o .exe from WSL #43948
Open
hrishikesh-kadam
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
hrishikesh-kadam:feature-request-43861
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
build: shim for invoking node w/o .exe from WSL #43948
hrishikesh-kadam
wants to merge
1
commit into
nodejs:main
from
hrishikesh-kadam:feature-request-43861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
install
Issues and PRs related to the installers.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
windows
Issues and PRs related to the Windows platform.
labels
Jul 22, 2022
hrishikesh-kadam
force-pushed
the
feature-request-43861
branch
from
July 22, 2022 18:49
7295f00
to
04e8794
Compare
This issue has been described in - nodejs#43861 Reason for using build subsystem - Shims will be just copied in the stage_package label of vcbuild.bat Fixes: nodejs#43861
hrishikesh-kadam
force-pushed
the
feature-request-43861
branch
from
July 23, 2022 10:08
04e8794
to
4895d42
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 23, 2022
This was referenced Jul 24, 2022
bnoordhuis
reviewed
Jan 14, 2023
Comment on lines
+443
to
+444
copy /Y ..\tools\msvs\node %TARGET_NAME%\ > nul | ||
if errorlevel 1 echo Cannot copy node && goto package_error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this affect non-WSL? What happens when I type node
in cmd.exe? In cygwin's bash.exe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been described in -
#43861
Reason for using build subsystem -
Shims will be just copied in the stage_package label of vcbuild.bat
Fixes: #43861