Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: shim for invoking node w/o .exe from WSL #43948

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hrishikesh-kadam
Copy link
Contributor

This issue has been described in -
#43861

Reason for using build subsystem -
Shims will be just copied in the stage_package label of vcbuild.bat

Fixes: #43861

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Jul 22, 2022
@hrishikesh-kadam hrishikesh-kadam marked this pull request as draft July 22, 2022 18:21
@hrishikesh-kadam hrishikesh-kadam marked this pull request as ready for review July 22, 2022 18:59
@hrishikesh-kadam hrishikesh-kadam marked this pull request as draft July 23, 2022 05:39
This issue has been described in -
nodejs#43861

Reason for using build subsystem -
Shims will be just copied in the stage_package label of vcbuild.bat

Fixes: nodejs#43861
@hrishikesh-kadam hrishikesh-kadam marked this pull request as ready for review July 23, 2022 10:09
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Comment on lines +443 to +444
copy /Y ..\tools\msvs\node %TARGET_NAME%\ > nul
if errorlevel 1 echo Cannot copy node && goto package_error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect non-WSL? What happens when I type node in cmd.exe? In cygwin's bash.exe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node shell shim missing in Windows installation node, required for WSL
4 participants