-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove unnecessary cast in crypto_sig.cc #44001
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:src-convertsignaturetoder-reinterpret
Jul 27, 2022
Merged
src: remove unnecessary cast in crypto_sig.cc #44001
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:src-convertsignaturetoder-reinterpret
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: nodejs#43202
tniessen
added
c++
Issues and PRs that require attention from people who are familiar with C++.
fast-track
PRs that do not need to wait for 48 hours to land.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 26, 2022
Review requested:
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
nodejs-github-bot
added
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 26, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 26, 2022
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Jul 26, 2022
16 tasks
RaisinTen
approved these changes
Jul 27, 2022
F3n67u
approved these changes
Jul 27, 2022
F3n67u
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jul 27, 2022
@F3n67u did you mean to apply |
@RaisinTen sorry. I don't see there is already a ci run |
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 27, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jul 27, 2022
Landed in abddacb |
This was referenced Aug 1, 2022
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: nodejs#43202 PR-URL: nodejs#44001 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByteSource::Allocated
accepts avoid
pointer now, so we do not need to cast the argument to achar
pointer.Refs: #43202