Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix bug in GetErrorSource() #44019

Closed
wants to merge 1 commit into from
Closed

src: fix bug in GetErrorSource() #44019

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Reported by static analysis. I assume this was supposed to dereference the bool*.

There does not seem to be a test covering (*added_exception_line) == false and I'm not familiar enough with this part of the code base to come up with one quickly.

Refs: #43875

@tniessen tniessen requested a review from legendecas July 28, 2022 08:18
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 28, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2022
@tniessen tniessen requested a review from bcoe July 28, 2022 08:54
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45717/

legendecas
legendecas approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! I'll come up with a test case later today.

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45731/

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 29, 2022
@tniessen tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 29, 2022
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2022
@legendecas
Copy link
Member

Landed in f2afcad

legendecas pushed a commit that referenced this pull request Jul 30, 2022
@tniessen @legendecas
src: fix bug in GetErrorSource()
f2afcad 
Refs: #43875

PR-URL: #44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@legendecas legendecas closed this Jul 30, 2022
@tniessen tniessen removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2022
@legendecas legendecas mentioned this pull request Jul 30, 2022
Closed
legendecas added a commit that referenced this pull request Aug 6, 2022
@legendecas
src,lib: print prinstine source when source map source not found
0a2c910 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@tniessen @danielleadams
src: fix bug in GetErrorSource()
6343e1d 
Refs: #43875

PR-URL: #44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@legendecas @danielleadams
src,lib: print prinstine source when source map source not found
63b5c49 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@tniessen @ruyadorno
src: fix bug in GetErrorSource()
b90b8ab 
Refs: #43875

PR-URL: #44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@legendecas @ruyadorno
src,lib: print prinstine source when source map source not found
ee6412a 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: #44052
Refs: #44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@tniessen @Fyko
src: fix bug in GetErrorSource()
c337556 
Refs: nodejs#43875

PR-URL: nodejs#44019
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@legendecas @Fyko
src,lib: print prinstine source when source map source not found
fb180fb 
Print unmapped source lines when the source map source is not
found. Error stacks should be correctly mapped even when the
source is absent.

PR-URL: nodejs#44052
Refs: nodejs#44019
Reviewed-By: Ben Coe <bencoe@gmail.com>
@targos
Copy link
Member

targos commented Sep 16, 2022

Depends on #43875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@F3n67u F3n67u F3n67u approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tniessen @nodejs-github-bot @legendecas @targos @bnoordhuis @richardlau @F3n67u