test: fix parallel/test-cluster-primary-error.js #44066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Jul 31, 2022
theanarkh
force-pushed
the
fix_test_cluster_primary_error
branch
from
7fa9a44
to
ae7be08
Compare
|
Is this test known to fail in non-ASan builds? |
|
I have not noticed that. I often see this case fail, so I try to fix it. |
|
I know it flakes in ASan a lot. But I am not sure if I ever saw it fail on any other system, and I don't see any records of it in nodejs/reliability. So if PID reuse is the issue, I am wondering why this only seems to happen under ASan. (IIRC, PID reuse is somewhat unlikely with newer Linux kernels.) |
|
I will keep an eye for this test case to see if it will fail on other systems. |
jasnell
approved these changes
Aug 28, 2022
github-actions
bot
removed
the
request-ci
This was referenced Aug 31, 2022
github-actions
bot
removed
the
request-ci
theanarkh
force-pushed
the
fix_test_cluster_primary_error
branch
from
ae7be08
to
18f5997
Compare
theanarkh
force-pushed
the
fix_test_cluster_primary_error
branch
from
18f5997
to
e001cd7
Compare
This was referenced Dec 22, 2022
This was referenced Dec 26, 2022
This was referenced Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix parallel/test-cluster-primary-error.js
Refs: #43970
Refs: #39655
make -j4 test(UNIX), orvcbuild test(Windows) passes