Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove usages of GetBackingStore in crypto #44079

Merged
merged 2 commits into from
Aug 4, 2022
Merged

src: remove usages of GetBackingStore in crypto #44079

merged 2 commits into from
Aug 4, 2022

Commits on Aug 1, 2022

  1. src: remove usages of GetBackingStore in crypto 

    This removes all usages of GetBackingStore in `crypto`. See the
linked issue for an explanation.

Note: I am not sure of the lifetime semantics intended by
`ArrayBufferOrViewContents` -- I am pretty sure it is correct based on
a manual audit of the callsites, but please ensure that it is correct.

Refs: nodejs#32226
Refs: nodejs#43921
    @kvakil
    kvakil committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    55bcf9a View commit details
    Browse the repository at this point in the history

  2. fixup! src: remove usages of GetBackingStore in crypto

    @kvakil
    kvakil committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    bba5c5e View commit details
    Browse the repository at this point in the history