test: revert cf503052 #4410
Closed
test: revert cf503052 #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#4410 As @Trott points out in nodejs#4364 commit cf50305 is currently breaking CI. This commit reverts the changes.
MylesBorins
force-pushed
the
revert-cf50305
branch
from
6a72596
to
9500a08
Compare
|
And just to make sure I'm not Completely Wrong About Everything (because that certainly happens more often than I'd like to admit), here's CI on current master to confirm the failures: https://ci.nodejs.org/job/node-test-commit/1514/ |
mscdex
added
domain
|
Reverted wrong commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Trott points out in #4364 commit cf50305 is currently
breaking CI. This commit reverts the changes.