-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update Web Streams WPT #44234
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
daeyeon:main.wpt-streams-220812.Fri.537a
Aug 17, 2022
Merged
test: update Web Streams WPT #44234
nodejs-github-bot
merged 1 commit into
nodejs:main
from
daeyeon:main.wpt-streams-220812.Fri.537a
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Aug 14, 2022
daeyeon
force-pushed
the
main.wpt-streams-220812.Fri.537a
branch
2 times, most recently
from
August 14, 2022 14:38
dc1a924
to
6f78a5b
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 14, 2022
daeyeon
force-pushed
the
main.wpt-streams-220812.Fri.537a
branch
from
August 14, 2022 16:59
6f78a5b
to
1012e97
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 14, 2022
panva
approved these changes
Aug 14, 2022
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Aug 14, 2022
joyeecheung
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
This updates the tests and the status file via running `git node wpt streams`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
daeyeon
force-pushed
the
main.wpt-streams-220812.Fri.537a
branch
from
August 16, 2022 04:33
1012e97
to
38d2558
Compare
Rebased to resolve conflicts. ( |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2022
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 16, 2022
9 tasks
aduh95
approved these changes
Aug 17, 2022
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 17, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 17, 2022
Landed in 6dde810 |
This was referenced Aug 18, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
This updates the tests and the status file via running `git node wpt streams`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #44234 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
This updates the tests and the status file via running `git node wpt streams`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs#44234 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
web streams
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the tests and the status file via running
git node wpt streams
.Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com