Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use if constexpr where appropriate #44291

Merged
merged 1 commit into from
Aug 27, 2022
Merged

src: use if constexpr where appropriate #44291

merged 1 commit into from
Aug 27, 2022

Conversation

addaleax
Copy link
Member

Doesn't change much but communicates to readers that these
are compile-time conditionals.

@addaleax
src: use if constexpr where appropriate
ef09e65 
Doesn't change much but communicates to readers that these
are compile-time conditionals.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 19, 2022
@targos
Copy link
Member

targos commented Aug 19, 2022

This is C++17, right?

mcollina
mcollina approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax
Copy link
Member Author

This is C++17, right?

Yes 👍

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46079/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit ee75ad7 into nodejs:main Aug 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ee75ad7

RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
@addaleax @RafaelGSS
src: use if constexpr where appropriate
7f16177 
Doesn't change much but communicates to readers that these
are compile-time conditionals.

PR-URL: #44291
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 5, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@addaleax @Fyko
src: use if constexpr where appropriate
b685b28 
Doesn't change much but communicates to readers that these
are compile-time conditionals.

PR-URL: nodejs#44291
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F3n67u F3n67u F3n67u approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @targos @mcollina @Trott @cjihrig @F3n67u @aduh95