Revert "build: go faster, drop -fno-omit-frame-pointer" #44566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0f73d3. The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions.
|
Review requested:
|
nodejs-github-bot
added
build
gengjiawen
approved these changes
Sep 8, 2022
gengjiawen
added
the
fast-track
|
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
Flarna
approved these changes
Sep 8, 2022
tniessen
approved these changes
Sep 8, 2022
VoltrexKeyva
approved these changes
Sep 8, 2022
RaisinTen
approved these changes
Sep 8, 2022
Trott
approved these changes
Sep 8, 2022
Trott
added
the
author ready
cjihrig
approved these changes
Sep 8, 2022
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Sep 8, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8a15f32 |
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
This reverts commit d0f73d3. The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions. PR-URL: nodejs#44566 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
This reverts commit d0f73d3. The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions. PR-URL: #44566 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
This reverts commit d0f73d3. The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions. PR-URL: #44566 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 26, 2022
This reverts commit d0f73d3. The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions. PR-URL: #44566 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d0f73d3.
The lack of frame pointers unfortunately breaks the --perf_basic_prof flag because perf(1) then no longer understands C++ <-> JS stack frame transitions.
Profiling with perf is probably common enough that (unlike postmortem debugging) people will notice when it's broken so revert it is.