test: move watch mode tests to sequential #44610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
MoLow
added
the
flaky-test
cjihrig
approved these changes
Sep 12, 2022
github-actions
bot
removed
the
request-ci
Linkgoron
approved these changes
Sep 12, 2022
MoLow
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44610 ✔ Done loading data for nodejs/node/pull/44610 ----------------------------------- PR info ------------------------------------ Title test: move watch mode tests to sequential (#44610) Author Moshe Atlow (@MoLow) Branch MoLow:move-watch-mode-test-to-sequential -> nodejs:main Labels test, flaky-test, fast-track, author ready, needs-ci Commits 1 - test: move watch mode tests to sequential Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/44610 Reviewed-By: Colin Ihrig Reviewed-By: Nitzan Uziely ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44610 Reviewed-By: Colin Ihrig Reviewed-By: Nitzan Uziely -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Sep 2022 10:20:34 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44610#pullrequestreview-1104128890 ✔ - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/44610#pullrequestreview-1104258489 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-12T13:50:16Z: https://ci.nodejs.org/job/node-test-pull-request/46548/ - Querying data for job/node-test-pull-request/46548/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3040106060 |
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/44610 ✔ Done loading data for nodejs/node/pull/44610 ----------------------------------- PR info ------------------------------------ Title test: move watch mode tests to sequential (#44610) Author Moshe Atlow (@MoLow) Branch MoLow:move-watch-mode-test-to-sequential -> nodejs:main Labels test, flaky-test, fast-track, author ready, needs-ci Commits 1 - test: move watch mode tests to sequential Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/44610 Reviewed-By: Colin Ihrig Reviewed-By: Nitzan Uziely ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44610 Reviewed-By: Colin Ihrig Reviewed-By: Nitzan Uziely -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Sep 2022 10:20:34 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44610#pullrequestreview-1104128890 ✔ - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/44610#pullrequestreview-1104258489 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-12T19:45:26Z: https://ci.nodejs.org/job/node-test-pull-request/46548/ - Querying data for job/node-test-pull-request/46548/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3040437712 |
nodejs-github-bot
added
the
commit-queue-failed
|
superseded by #44621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #44366 (comment)