Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clarify role of domains in microtask queue tests #4474

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/parallel/test-microtask-queue-integration-domain.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
'use strict';
require('../common');
var assert = require('assert');
var domain = require('domain');

// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');

var implementations = [
function(fn) {
Expand Down
8 changes: 7 additions & 1 deletion test/parallel/test-microtask-queue-run-domain.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
'use strict';
require('../common');
var assert = require('assert');
var domain = require('domain');

// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');

function enqueueMicrotask(fn) {
Promise.resolve().then(fn);
Expand Down
8 changes: 7 additions & 1 deletion test/parallel/test-microtask-queue-run-immediate-domain.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
'use strict';
require('../common');
var assert = require('assert');
var domain = require('domain');

// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');

function enqueueMicrotask(fn) {
Promise.resolve().then(fn);
Expand Down