Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add notable changes to latest v18.x release changelog #44996

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Oct 14, 2022

This adds the Notable changes header to the v18.11.0 CHANGELOG. It is needed to generate the release post with the release notes. (Coded in here: https://github.com/nodejs/nodejs.org/blob/main/scripts/release-post.js#L111-L125)

@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Oct 14, 2022
@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

danielleadams added a commit that referenced this pull request Oct 14, 2022
PR-URL: #44996
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@danielleadams
Copy link
Contributor Author

Landed in 37e5152

@danielleadams danielleadams deleted the add-notable-changes-to-18.11.0 branch October 14, 2022 04:13
danielleadams added a commit that referenced this pull request Dec 30, 2022
PR-URL: #44996
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams added a commit that referenced this pull request Dec 30, 2022
PR-URL: #44996
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams added a commit that referenced this pull request Jan 3, 2023
PR-URL: #44996
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos removed the release Issues and PRs related to Node.js releases. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants