-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add notable changes to latest v18.x release changelog #44996
Closed
danielleadams
wants to merge
1
commit into
nodejs:main
from
danielleadams:add-notable-changes-to-18.11.0
Closed
doc: add notable changes to latest v18.x release changelog #44996
danielleadams
wants to merge
1
commit into
nodejs:main
from
danielleadams:add-notable-changes-to-18.11.0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Oct 14, 2022
richardlau
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Oct 14, 2022
Fast-track has been requested by @richardlau. Please 👍 to approve. |
MoLow
approved these changes
Oct 14, 2022
danielleadams
force-pushed
the
add-notable-changes-to-18.11.0
branch
from
October 14, 2022 04:00
b328663
to
7df1aa5
Compare
MoLow
approved these changes
Oct 14, 2022
danielleadams
added a commit
that referenced
this pull request
Oct 14, 2022
PR-URL: #44996 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Landed in 37e5152 |
danielleadams
added a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44996 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
added a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44996 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams
added a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44996 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
Notable changes
header to the v18.11.0 CHANGELOG. It is needed to generate the release post with the release notes. (Coded in here: https://github.com/nodejs/nodejs.org/blob/main/scripts/release-post.js#L111-L125)