Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve the workflow to test release binaries #45004

Merged
merged 1 commit into from
Oct 15, 2022
Merged

doc: improve the workflow to test release binaries #45004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/contributing/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,13 +603,14 @@ the build before moving forward. Use the following list as a baseline:
must be in the expected updated version)
* npm version (check it matches what we expect)
* Run the test suite against the built binaries (optional)
* Remember to use the proposal branch
* Run `make build-addons` before running the tests
* Remove `config.gypi` file

```console
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
```

<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>
aduh95 marked this conversation as resolved.
Show resolved Hide resolved

### 11. Tag and sign the release commit

Once you have produced builds that you're happy with, create a new tag. By
Expand Down