test: watch mode inspect restart repeatedly #45060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Typo in commit: |
MoLow
force-pushed
the
make-wath-mode-inspect-test-more-robust
branch
from
1b8dbee to
04d4df4
Compare
Trott
changed the title
|
Cc @nodejs/testing |
|
@nodejs/fs |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
benjamingr
approved these changes
Oct 20, 2022
This comment was marked as outdated.
This comment was marked as outdated.
MoLow
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Oct 21, 2022
jasnell
approved these changes
Oct 22, 2022
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 47b63f5 |
This was referenced Oct 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44805
the timeout seems to occure when saving a single change of the file was not enough to trigger watch mode, so watch mode is triggerd repeatedly instead - until it succeeds to restart twice