deps: update ICU to 72.1 #45068

targos · 2022-10-19T11:01:11Z

Refs: https://github.com/unicode-org/icu/releases/tag/release-72-1

richardlau

LGTM but the commit title needs to be updated to reflect ICU 72.1 instead of 71.1.

Refs: https://github.com/unicode-org/icu/releases/tag/release-72-1

targos · 2022-10-19T12:32:45Z

Looks like I need to update some tests.

richardlau · 2022-10-19T12:43:10Z

Looks like I need to update some tests.

I'm assuming this from https://icu.unicode.org/download/72

In many formatting patterns, ASCII spaces are replaced with Unicode spaces (e.g., a "thin space").

fix tests

trailing comma

targos · 2022-10-19T16:34:24Z

/cc @nodejs/i18n-api

srl295 · 2022-10-19T17:01:45Z

LGTM but hold until it's actually released…

richardlau · 2022-10-19T17:10:29Z

test/parallel/test-icu-env.js

@@ -122,22 +122,22 @@ if (isMockable) {
  assert.deepStrictEqual(
    locales.map((LANG) => runEnvOutside({ LANG, TZ: 'Europe/Zurich' }, 'new Date(333333333333).toLocaleString()')),
    [
-      '7/25/1980, 1:35:33 AM',
+      '7/25/1980, 1:35:33 AM',


I suspect this will break the sharedlib ICU builds which will be using the previous format?

That's what happened. Should I make two branches depending on the ICU version?

Yes. I think technically the tests could be branched on the cldr version but in practice the ICU version is probably sufficient? At least we don't/haven't updated cldr independently of ICU version bumps up until now.

cc @srl295

this is always the case if you link with a backlevel ICU. I assume sharedlib = local system icu?

cldr doesn't usually update separate from icu

The change makes sense to me within any semverity.

Which change? Given that you added the test, do you think we need to consider the ICU 72.1 update a semver-major change?

I think it should be skipped unless the icu, cldr, tz, and unicode versions all match.

Makes sense, but should we concern about user-provided deps in our tests? If the version is heavily mismatched with bundled one, it might lead to test failures in other places as well anyway.

Which change?

The reviewed part, and the rest of changes in this file in this PR: https://github.com/nodejs/node/pull/45068/files#diff-a6095e09d738de6d1c78d336fac497210d041350d1ece89ef04491ff22bbf4b4L125-R135

Given that you added the test, do you think we need to consider the ICU 72.1 update a semver-major change?

No, the opposite: I consider changes in this file in this PR to be semver-patch, since it only slightly changes formatting in a few locales.

However, if the test would fail for a more serious reason (for example, adding a global cache for ICU that overrides environment variables even in freshly spawned process), I think it would be safer to not backport it.
The purpose of this test is to detect if something like that happens.

it might lead to test failures in other places as well anyway

That's an argument for not having such tests.

I'm trying to understand what the intent of testing is… is it to verify that ICU is integrated? Or that ICU's data never changes?

Because the data changes frequently. Some examples from the past few months: Sierra Leone revaluates its currency. Croatia switches to the Euro. Turkey is now Türkiye. Date formats change due to linguistic and geopolitical requests. Kazakhistan switches to Latin script. Etc…. the output here is not generally suitable for regression tests that are expected to pass in the future without modification.

CLDR 42 was released yesterday. here is the delta chart with some of the data changes. To give an idea of the magnitude of what changes from release to release.

targos · 2022-10-20T08:40:55Z

LGTM but hold until it's actually released…

I see, so the creation of the GitHub release doesn't mean that ICU is actually released. Is there another thing that I can subscribe to?

Edit: I subscribed to https://sourceforge.net/projects/icu/lists/icu-announce

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 fs.watch recursive support on Linux: `fs.watch` supports recursive watch using the `recursive: true` option. ```js const watcher = fs.watch(testDirectory, { recursive: true }); watcher.on('change', function(event, filename) { }); ``` Contributed by Yagiz Nizipli in #45098 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 Introduce `File`: The File class is part of the [FileAPI](https://w3c.github.io/FileAPI/). It can be used anywhere a Blob can, for example in `URL.createObjectURL` and `FormData`. It contains two properties that Blobs do not have: `lastModified`, the last time the file was modified in ms, and `name`, the name of the file. Contributed by Khafra in #45139 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

Refs: https://github.com/unicode-org/icu/releases/tag/release-72-1 PR-URL: #45068 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Notable changes: Add support for externally shared js builtins: By default Node.js is built so that all dependencies are bundled into the Node.js binary itself. Some Node.js distributions prefer to manage dependencies externally. There are existing build options that allow dependencies with native code to be externalized. This commit adds additional options so that dependencies with JavaScript code (including WASM) can also be externalized. This addition does not affect binaries shipped by the Node.js project but will allow other distributions to externalize additional dependencies when needed. Contributed by Michael Dawson in #44376 Introduce `File`: The File class is part of the [FileAPI](https://w3c.github.io/FileAPI/). It can be used anywhere a Blob can, for example in `URL.createObjectURL` and `FormData`. It contains two properties that Blobs do not have: `lastModified`, the last time the file was modified in ms, and `name`, the name of the file. Contributed by Khafra in #45139 Support function mocking on Node.js test runner: The `node:test` module supports mocking during testing via a top-level `mock` object. ```js test('spies on an object method', (t) => { const number = { value: 5, add(a) { return this.value + a; }, }; t.mock.method(number, 'add'); assert.strictEqual(number.add(3), 8); assert.strictEqual(number.add.mock.calls.length, 1); }); ``` Contributed by Colin Ihrig in #45326 Other notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 crypto: * update root certificates (Luigi Pinca) #45490 deps: * update ICU to 72.1 (Michaël Zasso) #45068 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael to the tsc (Michael Dawson) #45691 * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 * add lukekarrys to collaborators (Luke Karrys) #45180 * add anonrig to collaborators (Yagiz Nizipli) #45002 * deprecate url.parse() (Rich Trott) #44919 lib: * drop fetch experimental warning (Matteo Collina) #45287 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 * src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 * (SEMVER-MINOR) add initial shadow realm support (Chengzhong Wu) #42869 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * (SEMVER-MINOR) add "ca" property to certificate object (Ben Noordhuis) #44935 * remove trustcor root ca certificates (Ben Noordhuis) #45776 tools: * update certdata.txt (Luigi Pinca) #45490 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 * improve textdecoder decode performance (Yagiz Nizipli) #45294 * (SEMVER-MINOR) add MIME utilities (#21128) (Bradley Farias) #21128 PR-URL: #46025

nodejs/node#45068

* chore: bump node in DEPS to v18.13.0 * child_process: validate arguments for null bytes nodejs/node#44782 * bootstrap: merge main thread and worker thread initializations nodejs/node#44869 * module: ensure relative requires work from deleted directories nodejs/node#42384 * src: add support for externally shared js builtins nodejs/node#44000 * lib: disambiguate `native module` to `binding` nodejs/node#45673 * test: convert test-debugger-pid to async/await nodejs/node#45179 * deps: upgrade to libuv 1.44.2 nodejs/node#42340 * src: fix cppgc incompatibility in v8 nodejs/node#43521 * src: use qualified `std::move` call in node_http2 nodejs/node#45555 * build: fix env.h for cpp20 nodejs/node#45516 * test: remove experimental-wasm-threads flag nodejs/node#45074 * src: iwyu in cleanup_queue.cc nodejs/node#44983 * src: add missing include for `std::all_of` nodejs/node#45541 * deps: update ICU to 72.1 nodejs/node#45068 * chore: fixup patch indices * chore: remove errant semicolons - nodejs/node#44179 - nodejs/node#44193 * src: add support for externally shared js builtins nodejs/node#44376 * chore: add missing GN filenames * deps: update nghttp2 to 1.51.0 nodejs/node#45537 * chore: disable more Node.js snapshot tests The Snapshot feature is currently disabled * chore: disable ICU timezone tests Node.js uses a different version of ICU than Electron so they will often be out of sync. * chore: disable threadpool event tracing test Event tracing is not enabled in embedded Node.js * chore: fixup patch indices * chore: comments from review Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

Corepack manages multiple per-project version of Yarn and PNPM, which means we have to maintain less installation code, and could help us switch away from Yarn 1 without making the system unusable for development of other Yarn 1 projects. https://nodejs.org/api/corepack.html The Unicode spaces in the timerender test resulted from an ICU upgrade: nodejs/node#45068. Signed-off-by: Anders Kaseorg <anders@zulip.com>

* chore: bump node in DEPS to v18.13.0 * child_process: validate arguments for null bytes nodejs/node#44782 * bootstrap: merge main thread and worker thread initializations nodejs/node#44869 * module: ensure relative requires work from deleted directories nodejs/node#42384 * src: add support for externally shared js builtins nodejs/node#44000 * lib: disambiguate `native module` to `binding` nodejs/node#45673 * test: convert test-debugger-pid to async/await nodejs/node#45179 * deps: upgrade to libuv 1.44.2 nodejs/node#42340 * src: fix cppgc incompatibility in v8 nodejs/node#43521 * src: use qualified `std::move` call in node_http2 nodejs/node#45555 * build: fix env.h for cpp20 nodejs/node#45516 * test: remove experimental-wasm-threads flag nodejs/node#45074 * src: iwyu in cleanup_queue.cc nodejs/node#44983 * src: add missing include for `std::all_of` nodejs/node#45541 * deps: update ICU to 72.1 nodejs/node#45068 * chore: fixup patch indices * chore: remove errant semicolons - nodejs/node#44179 - nodejs/node#44193 * src: add support for externally shared js builtins nodejs/node#44376 * chore: add missing GN filenames * deps: update nghttp2 to 1.51.0 nodejs/node#45537 * chore: disable more Node.js snapshot tests The Snapshot feature is currently disabled * chore: disable ICU timezone tests Node.js uses a different version of ICU than Electron so they will often be out of sync. * chore: disable threadpool event tracing test Event tracing is not enabled in embedded Node.js * chore: fixup patch indices * chore: comments from review Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

srl295 · 2023-04-06T16:22:53Z

Hi 👋 I'm going to give ICU4C 73.1 RC a try with latest node…
… Edit, seems to build OK

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Oct 19, 2022

richardlau approved these changes Oct 19, 2022

View reviewed changes

targos changed the title ~~deps: update ICU to 71.1~~ deps: update ICU to 72.1 Oct 19, 2022

deps: update ICU to 72.1

fd144b5

Refs: https://github.com/unicode-org/icu/releases/tag/release-72-1

targos force-pushed the icu-72 branch from b051d8c to fd144b5 Compare October 19, 2022 11:52

targos added request-ci Add this label to start a Jenkins CI on a PR. icu Issues and PRs related to the ICU dependency. labels Oct 19, 2022

VoltrexKeyva approved these changes Oct 19, 2022

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022

This comment was marked as outdated.

Sign in to view

targos added 2 commits October 19, 2022 18:30

fixup! deps: update ICU to 72.1

d7bd0b7

fix tests

fixup! fixup! deps: update ICU to 72.1

27dd1c4

trailing comma

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022

This comment was marked as outdated.

Sign in to view

srl295 approved these changes Oct 19, 2022

View reviewed changes

richardlau reviewed Oct 19, 2022

View reviewed changes

targos added the blocked PRs that are blocked by other issues or PRs. label Oct 19, 2022

jasnell approved these changes Oct 19, 2022

View reviewed changes

srl295 mentioned this pull request Oct 19, 2022

Changes in V8/ICU behaviour should be detected&tested&documented|overridden #42440

Open

github-actions bot mentioned this pull request Oct 20, 2022

CI Reliability 2022-10-20 nodejs/reliability#405

Open

10 tasks

fixup! fixup! fixup! deps: update ICU to 72.1

f347c53

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2022

bliu13 mentioned this pull request Jan 7, 2023

Inconsistent DateTime format when using toLocaleString moment/luxon#1333

Closed

codebytere added a commit to electron/electron that referenced this pull request Jan 9, 2023

deps: update ICU to 72.1

acd98d3

nodejs/node#45068

codebytere added a commit to electron/electron that referenced this pull request Jan 9, 2023

deps: update ICU to 72.1

046004c

nodejs/node#45068

keepitterron mentioned this pull request Jan 10, 2023

toLocaleDateString not working as expected on latest node 18 #46162

Closed

twschiller mentioned this pull request Jan 14, 2023

Broken snapshots on CI due to unicode character pixiebrix/pixiebrix-extension#5010

Closed

mauromascarenhas mentioned this pull request Jan 30, 2023

Date.prototype.toLocaleString behaviour changed between minor versions #46431

Closed

andersk mentioned this pull request Feb 9, 2023

Incorrect Unicode space character in return value from Date.prototype.toLocaleTimeString nodejs/help#4068

Closed

christophflick-toast mentioned this pull request Feb 14, 2023

Support U+202F / NARROW NO-BREAK SPACE in input strings date-fns/date-fns#3348

Closed

srl295 mentioned this pull request Apr 6, 2023

deps: update ICU to 73.1 final #47456

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update ICU to 72.1 #45068

deps: update ICU to 72.1 #45068

targos commented Oct 19, 2022

richardlau left a comment

This comment was marked as outdated.

targos commented Oct 19, 2022

richardlau commented Oct 19, 2022

targos commented Oct 19, 2022

This comment was marked as outdated.

srl295 commented Oct 19, 2022

richardlau Oct 19, 2022

targos Oct 19, 2022

richardlau Oct 19, 2022

srl295 Oct 19, 2022

srl295 Oct 19, 2022

targos Oct 20, 2022

LiviaMedeiros Oct 20, 2022

LiviaMedeiros Oct 20, 2022

srl295 Oct 20, 2022

srl295 Oct 20, 2022

targos commented Oct 20, 2022 •

edited

Loading

srl295 commented Apr 6, 2023 •

edited

Loading

deps: update ICU to 72.1 #45068

deps: update ICU to 72.1 #45068

Conversation

targos commented Oct 19, 2022

richardlau left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

targos commented Oct 19, 2022

richardlau commented Oct 19, 2022

targos commented Oct 19, 2022

This comment was marked as outdated.

srl295 commented Oct 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

targos commented Oct 20, 2022 • edited Loading

srl295 commented Apr 6, 2023 • edited Loading

targos commented Oct 20, 2022 •

edited

Loading

srl295 commented Apr 6, 2023 •

edited

Loading