-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix v14.x link maintaining openssl guide #45071
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
RafaelGSS
force-pushed
the
doc/maintaining-openssl-v14-fix
branch
from
October 19, 2022 12:40
1337e2b
to
c04409f
Compare
richardlau
reviewed
Oct 19, 2022
RafaelGSS
force-pushed
the
doc/maintaining-openssl-v14-fix
branch
from
October 19, 2022 13:36
c04409f
to
b571a73
Compare
richardlau
approved these changes
Oct 19, 2022
Why adding a link for v14.x and not v16.x? |
The v16.x version of that document exists. The issue is that the v14.x of that document lives in a different namespace (guides/*) |
Oh you mean on the GitHub UI, yeah OK makes sense. |
mcollina
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jasnell
reviewed
Oct 19, 2022
RafaelGSS
force-pushed
the
doc/maintaining-openssl-v14-fix
branch
from
October 22, 2022 04:11
b571a73
to
8231341
Compare
RafaelGSS
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Oct 22, 2022
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Oct 22, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45071 ✔ Done loading data for nodejs/node/pull/45071 ----------------------------------- PR info ------------------------------------ Title doc: fix v14.x link maintaining openssl guide (#45071) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc/maintaining-openssl-v14-fix -> nodejs:main Labels doc, author ready Commits 1 - doc: fix v14.x link maintaining openssl guide Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/45071 Reviewed-By: Richard Lau Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45071 Reviewed-By: Richard Lau Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: fix v14.x link maintaining openssl guide ℹ This PR was created on Wed, 19 Oct 2022 12:31:55 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45071#pullrequestreview-1147646586 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45071#pullrequestreview-1148034313 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3303153329 |
RafaelGSS
added a commit
that referenced
this pull request
Oct 22, 2022
PR-URL: #45071 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Landed in 3a4f964 |
RafaelGSS
added a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45071 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
RafaelGSS
added a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45071 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45071 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45071 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45071 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document indicates the file lives under
/blob/v14.x-staging/doc/contributing/maintaining-openssl.md
which is false on v14.x branch.