Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: avoid generating snapshot blobs outside tmpdir #45137

Closed
wants to merge 1 commit into from
Closed

test: avoid generating snapshot blobs outside tmpdir #45137

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Oct 23, 2022 •
edited
Loading

Fixes: #45017
Refs: #44903

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 23, 2022
@Trott
Copy link
Member

Trott commented Oct 23, 2022

Duplicate of #45132?

@legendecas
Copy link
Member Author

Closed in duplicate of #45132.

@legendecas legendecas closed this Oct 24, 2022
@legendecas legendecas deleted the test/fix-snapshot-blob branch October 24, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

running tests leaves snapshot.blob file in workspace
4 participants
@legendecas @Trott @jasnell @nodejs-github-bot