Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: call {before,after}Each() on suites #45161

Merged
merged 1 commit into from
Oct 27, 2022
Merged

test_runner: call {before,after}Each() on suites #45161

merged 1 commit into from
Oct 27, 2022

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 25, 2022

Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that.

Fixes: #45028

@cjihrig
test_runner: call {before,after}Each() on suites
94f4247 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 25, 2022
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47468/

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 26, 2022
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit a69a300 into nodejs:main Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a69a300

@cjihrig cjihrig deleted the describe branch October 27, 2022 12:42
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@cjihrig @RafaelGSS
test_runner: call {before,after}Each() on suites
c837b26 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@cjihrig @RafaelGSS
test_runner: call {before,after}Each() on suites
afa8291 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
008f95d 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
PR-URL: nodejs#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
3a6a44f 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
PR-URL: nodejs#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow MoLow mentioned this pull request Nov 24, 2022
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
51c7b47 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
PR-URL: nodejs#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cjihrig @danielleadams
test_runner: call {before,after}Each() on suites
b7b9e06 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cjihrig @danielleadams
test_runner: call {before,after}Each() on suites
deb773b 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@cjihrig @danielleadams
test_runner: call {before,after}Each() on suites
a59c907 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
5810158 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: call {before,after}Each() on suites
b55c81d 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: call {before,after}Each() on suites
c0c3dde 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: call {before,after}Each() on suites
0bfdb77 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
@MoLow MoLow mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

describe block without it does not trigger hooks
5 participants
@cjihrig @nodejs-github-bot @jasnell @anonrig @MoLow