Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix icu-small build on mac with ICU 72.1 #45195

Merged
merged 1 commit into from
Oct 27, 2022
Merged

build: fix icu-small build on mac with ICU 72.1 #45195

merged 1 commit into from
Oct 27, 2022

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 26, 2022 •
edited by aduh95
Loading

  • RTTI is needed for genrb now

Fixes: #45174

@srl295 srl295 self-assigned this Oct 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 26, 2022
@srl295 srl295 mentioned this pull request Oct 26, 2022
Closed
@srl295
build: fix icu-small build on mac with ICU 72.1
8d832f9 
- RTTI is needed for genrb now

Fixes: nodejs#45174
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2022
@richardlau
Copy link
Member

I don't have a mac to test this on but I can check on Linux tomorrow. I'd like to get nodejs/build#2998 set up but that doesn't need to block this.

@srl295
Copy link
Member Author

srl295 commented Oct 26, 2022

I don't have a mac to test this on but I can check on Linux tomorrow. I'd like to get nodejs/build#2998 set up but that doesn't need to block this.

yeah, the problem might not repro if not on a mac.

aduh95
aduh95 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I'm able to build on this branch and with icu-small on macOS 12.6.

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 26, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2022
anonrig
anonrig approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau
Copy link
Member

FTR #45174 reproduces in RHEL 8 x64 with configure --with-intl=small-icu and I can confirm this PR fixes it there as well (so this is not a mac-specific issue).

@srl295
Copy link
Member Author

srl295 commented Oct 27, 2022 via email

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47502/

@srl295
Copy link
Member Author

srl295 commented Oct 27, 2022

Is this ready to land?

@aduh95 aduh95 merged commit 8fdac20 into nodejs:main Oct 27, 2022
@aduh95
Copy link
Contributor

aduh95 commented Oct 27, 2022

Landed in 8fdac20, thanks!

@srl295
Copy link
Member Author

srl295 commented Oct 27, 2022

@aduh95 you got it. thanks

@srl295 srl295 deleted the srl295/issue45174 branch October 27, 2022 19:24
This was referenced Oct 28, 2022
Open
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@srl295 @RafaelGSS
build: fix icu-small build with ICU 72.1
ba59911 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@srl295 @RafaelGSS
build: fix icu-small build with ICU 72.1
f598edb 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@srl295 @danielleadams
build: fix icu-small build with ICU 72.1
529100b 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@srl295 @danielleadams
build: fix icu-small build with ICU 72.1
0b21ae2 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@srl295 @danielleadams
build: fix icu-small build with ICU 72.1
abcc034 
- RTTI is needed for genrb now.

Fixes: #45174
PR-URL: #45195
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@targos targos Awaiting requested review from targos

Assignees

@srl295 srl295

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small ICU fails to build
8 participants
@srl295 @nodejs-github-bot @richardlau @aduh95 @Trott @lpinca @anonrig @gengjiawen