Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] deps: patch V8 to 10.2.154.19 #45229

Closed
wants to merge 1 commit into from
Closed

[v18.x] deps: patch V8 to 10.2.154.19 #45229

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 29, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Oct 29, 2022
@targos targos added dont-land-on-v14.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47547/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4947/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4947/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4947/

This was referenced Oct 30, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47588/

gengjiawen
gengjiawen reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks you forget update common.gypi

@targos
Copy link
Member Author

targos commented Oct 31, 2022 •
edited
Loading

@gengjiawen you mean the embedder string? We don't update it for official V8 patches, as they already change another part of the version string (V8_PATCH_LEVEL).

@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
17 tasks
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47615/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4953/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4953/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4953/

@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Open
15 tasks
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2022
@targos targos removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 5, 2022
targos added a commit that referenced this pull request Nov 5, 2022
@targos
deps: patch V8 to 10.2.154.19
2e621c3 
Refs: v8/v8@10.2.154.15...10.2.154.19
PR-URL: #45229
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos
Copy link
Member Author

targos commented Nov 5, 2022

Landed in 2e621c3

@targos targos closed this Nov 5, 2022
@targos targos deleted the v8-107-18-v18 branch November 5, 2022 08:59
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@targos @danielleadams
deps: patch V8 to 10.2.154.19
5c0fcc1 
Refs: v8/v8@10.2.154.15...10.2.154.19
PR-URL: #45229
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @nodejs-github-bot @gengjiawen