Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: avoid premature close when will not emit close #45301

Merged
merged 2 commits into from
Nov 20, 2022
Merged

stream: avoid premature close when will not emit close #45301

merged 2 commits into from
Nov 20, 2022
+30 −4

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 3, 2022

Fixes: #45281

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Nov 3, 2022
@ronag ronag requested a review from mcollina November 3, 2022 14:12
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@ronag
Copy link
Member Author

ronag commented Nov 3, 2022

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 3, 2022
mcollina
mcollina approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48003/

This was referenced Nov 19, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48042/

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45301
✔  Done loading data for nodejs/node/pull/45301
----------------------------------- PR info ------------------------------------
Title      stream: avoid premature close when will not emit close (#45301)
Author     Robert Nagy  (@ronag)
Branch     ronag:fix45281 -> nodejs:main
Labels     stream, author ready, commit-queue-squash
Commits    2
 - stream: avoid premature close when will not emit close
 - fixup lint
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/45301
Fixes: https://github.com/nodejs/node/issues/45281
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Minwoo Jung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45301
Fixes: https://github.com/nodejs/node/issues/45281
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Minwoo Jung 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - fixup lint
   ℹ  This PR was created on Thu, 03 Nov 2022 14:12:28 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45301#pullrequestreview-1167360992
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45301#pullrequestreview-1167527484
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45301#pullrequestreview-1167745607
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/45301#pullrequestreview-1185647423
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-20T11:00:52Z: https://ci.nodejs.org/job/node-test-pull-request/48042/
- Querying data for job/node-test-pull-request/48042/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3508098605

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 20, 2022
mcollina
mcollina approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5664822 into nodejs:main Nov 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5664822

@github-actions github-actions bot mentioned this pull request Nov 21, 2022
Open
15 tasks
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@ronag @ruyadorno
stream: avoid premature close when will not emit close
5274a8f 
Fixes: #45281
PR-URL: #45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@github-actions github-actions bot mentioned this pull request Nov 22, 2022
Open
15 tasks
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@ronag @marco-ippolito
stream: avoid premature close when will not emit close
d8d0102 
Fixes: nodejs#45281
PR-URL: nodejs#45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
@xdc0
Copy link

xdc0 commented Dec 16, 2022 •
edited
Loading

Is this patch planned for release on node 18 LTS?

danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ronag @danielleadams
stream: avoid premature close when will not emit close
ef1cca4 
Fixes: #45281
PR-URL: #45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ronag @danielleadams
stream: avoid premature close when will not emit close
45230a8 
Fixes: #45281
PR-URL: #45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@ronag @danielleadams
stream: avoid premature close when will not emit close
ac9a4ab 
Fixes: #45281
PR-URL: #45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@ronag @danielleadams
stream: avoid premature close when will not emit close
5f2bac6 
Fixes: #45281
PR-URL: #45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@ronag @danielleadams
stream: avoid premature close when will not emit close
8373378 
Fixes: #45281
PR-URL: #45301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stream.finished throws ERR_STREAM_PREMATURE_CLOSE when it shouldn't
7 participants
@ronag @nodejs-github-bot @xdc0 @mcollina @benjamingr @lpinca @JungMinu