test: skip test-fs-largefile if not enough disk space #45339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
|
My Jenkins CI didn't run out of space so I'm running just the macOS part of it again. I want to see that the test is actually skipped when ENOSPC happens. https://ci.nodejs.org/job/node-test-commit-osx/48467/ EDIT: And another one. https://ci.nodejs.org/job/node-test-commit-osx/48469/ EDIT: And one more. https://ci.nodejs.org/job/node-test-commit-osx/48470/ |
|
Here's another one: https://ci.nodejs.org/job/node-test-commit-osx/48483/ |
18 tasks
|
Hooray, it caught a failure that time! https://ci.nodejs.org/job/node-test-commit-osx/48483/nodes=osx1015/console
I think this is ready for review and landing. @anonrig @nodejs/testing |
anonrig
added
the
author ready
Linkgoron
approved these changes
Nov 7, 2022
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45339 ✔ Done loading data for nodejs/node/pull/45339 ----------------------------------- PR info ------------------------------------ Title test: skip test-fs-largefile if not enough disk space (#45339) Author Rich Trott (@Trott) Branch Trott:fix-fs -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: skip test-fs-largefile if not enough disk space Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/45339 Fixes: https://github.com/nodejs/build/issues/3071 Reviewed-By: Yagiz Nizipli Reviewed-By: Nitzan Uziely ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45339 Fixes: https://github.com/nodejs/build/issues/3071 Reviewed-By: Yagiz Nizipli Reviewed-By: Nitzan Uziely -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 06 Nov 2022 15:55:11 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564 ✔ - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-07T00:01:32Z: https://ci.nodejs.org/job/node-test-pull-request/47751/ - Querying data for job/node-test-pull-request/47751/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3412750367 |
Trott
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45339 ✔ Done loading data for nodejs/node/pull/45339 ----------------------------------- PR info ------------------------------------ Title test: skip test-fs-largefile if not enough disk space (#45339) Author Rich Trott (@Trott) Branch Trott:fix-fs -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: skip test-fs-largefile if not enough disk space Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/45339 Fixes: https://github.com/nodejs/build/issues/3071 Reviewed-By: Yagiz Nizipli Reviewed-By: Nitzan Uziely ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45339 Fixes: https://github.com/nodejs/build/issues/3071 Reviewed-By: Yagiz Nizipli Reviewed-By: Nitzan Uziely -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 06 Nov 2022 15:55:11 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564 ✔ - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-07T17:54:35Z: https://ci.nodejs.org/job/node-test-pull-request/47751/ - Querying data for job/node-test-pull-request/47751/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3412750367 |
Fixes: nodejs/build#3071 PR-URL: nodejs#45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
|
Landed in e080331 |
17 tasks
14 tasks
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
Fixes: nodejs/build#3071 PR-URL: nodejs#45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
20 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/build#3071
I'm guessing this is the test that then causes other cascading disk failures, but maybe there are others. Let's run CI here and find out....