Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: increase macOS cores to 3 on GitHub CI #45340

Merged
merged 1 commit into from
Nov 6, 2022
Merged

tools: increase macOS cores to 3 on GitHub CI #45340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ jobs:
# The `npm ci` for this step fails a lot as part of the Test step. Run it
# now so that we don't have to wait 2 hours for the Build step to pass
# first before that failure happens. (And if there's something about
# `make run-ci -j2` that is causing the failure and the failure doesn't
# `make run-ci -j3` that is causing the failure and the failure doesn't
# happen anymore running this step here first, that's also useful
# information.)
- name: tools/doc/node_modules workaround
run: make tools/doc/node_modules
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j3 V=1 CONFIG_FLAGS="--error-on-warn"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
run: make run-ci -j3 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott Can we get the core count using bash, and remove the need to update this workflow in the future? Something like getconf _NPROCESSORS_ONLN

Copy link
Member Author

@Trott Trott Nov 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're sure it returns the right number on virtual machines (instead of returning the number available to the physical host that the VM is running on), yeah, that would be great. I'm going to let this run as-is so we can confirm that -j3 is faster than -j2. I'll leave a comment about that on main.