Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix stability index generation #45346

Merged
merged 1 commit into from
Nov 7, 2022
Merged

tools: fix stability index generation #45346

merged 1 commit into from
Nov 7, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 6, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 6, 2022
@aduh95 aduh95 mentioned this pull request Nov 6, 2022
Closed
@Trott
Copy link
Member

Trott commented Nov 6, 2022 •
edited
Loading

An alternative is in f747806. I'm not sure which one is easier to understand. (I mean, I think it's the one I wrote, but that's because I wrote it.)

This looks good to me, though, and I suspect is the better fix.

@Trott Trott mentioned this pull request Nov 6, 2022
Closed
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 6, 2022

An alternative is in f747806. I'm not sure which one is easier to understand. (I mean, I think it's the one I wrote, but that's because I wrote it.)

This PR changes the JSON output, because I don't think having line returns in there is helpful, and it can break stuff as shown in the other PR. We could also land both PRs if we keep this one focused on the JSON output and yours on the stability index table generation. (I think that regex of yours is not easier to understand than this PR, but I don't feel strongly either way).

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47746/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47750/

@github-actions github-actions bot mentioned this pull request Nov 7, 2022
Open
18 tasks
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7e581c8 into nodejs:main Nov 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7e581c8

This was referenced Nov 8, 2022
Open
Open
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@aduh95
tools: fix stability index generation
86d8068 
PR-URL: nodejs#45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
tools: fix stability index generation
e275859 
PR-URL: #45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
tools: fix stability index generation
3e9f21e 
PR-URL: #45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
tools: fix stability index generation
eac9d16 
PR-URL: #45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
tools: fix stability index generation
5105060 
PR-URL: #45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@aduh95 @danielleadams
tools: fix stability index generation
93e27f8 
PR-URL: #45346
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @Trott @nodejs-github-bot @GeoffreyBooth