Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: stronger suggestion for userland assert #4535

Closed
wants to merge 4 commits into from
Closed

docs: stronger suggestion for userland assert #4535

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed29a58
docs: stronger suggestion for userland assert
geek Jan 5, 2016
07d5d48
Update assert.markdown
geek Jan 5, 2016
e6da014
Used wording from @cjihrig
geek Jan 5, 2016
581a3b1
With feedback from @jasnell
geek Jan 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/api/assert.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

Stability: 3 - Locked

The `assert` module provides a simple set of assertion tests that can be used
to test invariants and implement unit tests. While the `assert` module is
generally intended for internal use by Node.js itself, it can be used by user
code calling `require('assert')`.
The `assert` module provides a simple set of assertion tests that can be used to
test invariants. `assert` is intended for internal use by Node.js, but can be
used in application code via `require('assert')`. `assert` is not a testing
framework, and is not intended to be used as a general purpose assertion library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit... I'd like to avoid starting sentences with a lower-cased module name, especially two sentences in a row... Perhaps reword the las two sentences to:

The module is intended for internal use by Node.js, but can be used in application 
code via `require('assert')`. However, `assert` is not a testing framework, and is not 
intended to be used as a general purpose assertion library.

The API for the `assert` module is [Locked][]. This means that there will be no
additions or changes to any of the methods implemented and exposed by
Expand Down