Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: update todo message for detached buffers #45464

Closed
wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 14, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 14, 2022
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

@@ -142,6 +142,8 @@ function transferArrayBuffer(buffer) {
function isDetachedBuffer(buffer) {
if (ArrayBufferGetByteLength(buffer) === 0) {
// TODO(daeyeon): Consider using C++ builtin to improve performance.
// Replace this when current v8 is updated to include the following commit:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Replace this when current v8 is updated to include the following commit:
// Replace this when current V8 is updated to include the following commit:

@Trott
Copy link
Member

Trott commented Nov 15, 2022

LGTM, but you'll need to rebase against the main branch to pick up the fix for the linting problems.

@@ -142,6 +142,8 @@ function transferArrayBuffer(buffer) {
function isDetachedBuffer(buffer) {
if (ArrayBufferGetByteLength(buffer) === 0) {
// TODO(daeyeon): Consider using C++ builtin to improve performance.
// Replace this when current v8 is updated to include the following commit:
// https://chromium.googlesource.com/v8/v8/+/9df5ef70ff18977b157028fc55ced5af4bcee535
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems trivial, why don't we just backport it now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's better. I've opened #45474, and closing this pull request.

@anonrig
Copy link
Member Author

anonrig commented Nov 18, 2022

Closing this due to PR #45512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. web streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants