Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: export more OpenSSL symbols on Windows #45486

Merged
merged 2 commits into from
Jan 31, 2023
Merged

build: export more OpenSSL symbols on Windows #45486

merged 2 commits into from
Jan 31, 2023

Conversation

mohd-akram
Copy link
Contributor

Fixes #45445.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 16, 2022
@bnoordhuis bnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48237/

This was referenced Nov 30, 2022
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Open
8 tasks
@bnoordhuis bnoordhuis added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48574/

@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49223/

@gengjiawen
Copy link
Member

@mohd-akram The cpp linting is failed, see https://github.com/nodejs/node/actions/runs/3481978405/jobs/5825655808

@mohd-akram
Copy link
Contributor Author

I saw that, but it's for existing lines unrelated to the PR so I didn't change it. I'll fix it?

@gengjiawen
Copy link
Member

I saw that, but it's for existing lines unrelated to the PR so I didn't change it. I'll fix it?

That will be good. Looks the task only trigger on changed files.

@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49243/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49249/

@richardlau richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 30, 2023
@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2023
@gengjiawen gengjiawen added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3abd559 into nodejs:main Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 3abd559

@gengjiawen
Copy link
Member

@mohd-akram Thx for the contribution :)

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@mohd-akram @ruyadorno
build: export more OpenSSL symbols on Windows
8c6c433 
PR-URL: #45486
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
Merged
@ruyadorno
Copy link
Member

hi @gengjiawen just want to make sure this makes sense as a notable-change since at first glance it looked to me like it's only adding a missing symbol on a platform-specific version (windows).

Could you elaborate a bit more on why do you want to highlight that as a notable change for Node.js end-users? (Also if you do so, it's a good chance to put together a small write-up so that it shows up more than just the commit message in the changelog, similar to the ESM write-up in #46455) 😊 thanks in advance!

@mohd-akram mohd-akram deleted the fix-win-openssl-symbols branch February 1, 2023 15:50
@ruyadorno ruyadorno removed the notable-change PRs with changes that should be highlighted in changelogs. label Feb 1, 2023
@gengjiawen
Copy link
Member

Could you elaborate a bit more on why do you want to highlight that as a notable change for Node.js end-users?

Windows users can use more native functions in openssl like unix user.

@bnoordhuis
Copy link
Member

As a side effect, the binary may have become a fair bit bigger on Windows.

@ruyadorno
Copy link
Member

thank you @gengjiawen, unfortunately I had already closed the changelog and ran the release job yesterday in order to promote the builds today. sorry about that!

@gengjiawen
Copy link
Member

Adding the raw commit message in change won't hurt much. But missing it will make lots of people miss it.
I hope next time this will not be a blocker or not rushing release.

juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@mohd-akram @juanarbol
build: export more OpenSSL symbols on Windows
6e19f22 
PR-URL: #45486
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@mohd-akram @juanarbol
build: export more OpenSSL symbols on Windows
0a8e0a7 
PR-URL: #45486
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@mohd-akram @juanarbol
build: export more OpenSSL symbols on Windows
ec61bb0 
PR-URL: #45486
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MD5 symbols missing from Windows library
7 participants
@mohd-akram @nodejs-github-bot @gengjiawen @ruyadorno @bnoordhuis @jasnell @richardlau