Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing trailing commas in async-hooks tests #45549

Merged
merged 2 commits into from
Nov 21, 2022
Merged

test: add missing trailing commas in async-hooks tests #45549

merged 2 commits into from
Nov 21, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 20, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 20, 2022
@Trott
Copy link
Member

Trott commented Nov 21, 2022

Totally tiny nit, but I would drop the word "missing" from the commit message on PRs like this. Whether or not the trailing comma is "missing" might be a matter of interpretation, and "test: add trailing commas in async-hooks tests" conveys the same information more concisely anyway.

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45549
✔  Done loading data for nodejs/node/pull/45549
----------------------------------- PR info ------------------------------------
Title      test: add missing trailing commas in async-hooks tests (#45549)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:async-hooks-test-dangle -> nodejs:main
Labels     test, async_hooks, fast-track, author ready
Commits    1
 - test: add missing trailing commas in async-hooks tests
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/45549
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45549
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Rich Trott 
Reviewed-By: Moshe Atlow 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 20 Nov 2022 17:45:12 GMT
   ✔  Approvals: 4
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/45549#pullrequestreview-1187343928
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45549#pullrequestreview-1187383240
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45549#pullrequestreview-1188167512
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45549#pullrequestreview-1188177168
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3514762851

@daeyeon daeyeon added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 21, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48063/

@aduh95 aduh95 merged commit cf46746 into nodejs:main Nov 21, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 21, 2022

Landed in cf46746

@aduh95 aduh95 deleted the async-hooks-test-dangle branch November 21, 2022 17:43
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@aduh95 @ruyadorno
test: add trailing commas in async-hooks tests (#45549)
bb4c293 
PR-URL: #45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Nov 22, 2022
Open
Open
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@aduh95 @marco-ippolito
test: add trailing commas in async-hooks tests (nodejs#45549)
b1f5c14 
PR-URL: nodejs#45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actions github-actions bot mentioned this pull request Nov 24, 2022
Open
16 tasks
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test: add trailing commas in async-hooks tests (#45549)
fe81f8a 
PR-URL: #45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test: add trailing commas in async-hooks tests (#45549)
b76ce70 
PR-URL: #45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test: add trailing commas in async-hooks tests (#45549)
8f7109a 
PR-URL: #45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@aduh95 @danielleadams
test: add trailing commas in async-hooks tests (#45549)
28470ef 
PR-URL: #45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @danielleadams
test: add trailing commas in async-hooks tests (#45549)
af47a1c 
PR-URL: #45549
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@MoLow MoLow MoLow approved these changes

@daeyeon daeyeon daeyeon approved these changes

@anonrig anonrig anonrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @Trott @nodejs-github-bot @anonrig @daeyeon @MoLow @RaisinTen