test: fix test-watch-mode-inspect #45586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
MoLow
reviewed
Nov 23, 2022
MoLow
approved these changes
Nov 23, 2022
MoLow
added
test_runner
ErickWendel
approved these changes
Nov 23, 2022
|
Hi, is there something I can do to help move this forward? I've seen Test ASan failing, but it seems unrelated to my changes. |
github-actions
bot
removed
the
request-ci
Test ASan is failing because your branch doesn't have 3b1f389. If you rebase against the main branch and force push, that should fix it. (I tried to rebase and force push to your branch, but I don't have sufficient privileges to do that.) |
StefanStojanovic
force-pushed
the
mefi-watch-mode-inspect-test
branch
from
b8a699e
to
60372b9
Compare
github-actions
bot
removed
the
request-ci
Thanks, @Trott! Rebasing helped with Test ASan, but unfortunately, Also, I have another PR similar to this one (#45585), since it had the same issue as this one and I force-pushed it as well, I guess you'd want to add a |
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45586 ✔ Done loading data for nodejs/node/pull/45586 ----------------------------------- PR info ------------------------------------ Title test: fix test-watch-mode-inspect (#45586) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch StefanStojanovic:mefi-watch-mode-inspect-test -> nodejs:main Labels test, needs-ci, watch-mode Commits 1 - test: fix test-watch-mode-inspect Committers 1 - StefanStojanovic PR-URL: https://github.com/nodejs/node/pull/45586 Refs: https://github.com/nodejs/node/issues/44898 Reviewed-By: Moshe Atlow Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45586 Refs: https://github.com/nodejs/node/issues/44898 Reviewed-By: Moshe Atlow Reviewed-By: Erick Wendel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: fix test-watch-mode-inspect ℹ This PR was created on Tue, 22 Nov 2022 17:10:57 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45586#pullrequestreview-1191665656 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/45586#pullrequestreview-1191845641 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-12-01T16:56:08Z: https://ci.nodejs.org/job/node-test-pull-request/48266/ - Querying data for job/node-test-pull-request/48266/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3595374544 |
Trott
approved these changes
Dec 1, 2022
Trott
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2cad517 |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes flakiness in watch mode tests in
test/sequential/test-watch-mode-inspect.mjs. The changes made introduce a basic synchronization between restarting the process (rewriting the file) and its execution. Previously, it was possible to restart the process while it was still executing (while getting debugged PID) which caused the test to fail, and in some cases even leave it hanging.With these changes, one problem still persists. Rarely, in less than 1% of runs, logs from the start of the process, until the first restart are missing. Eg. instead of getting (inspector helper debug logs included)
test gets
It is worth noting that although
safe to debug nowis sometimes not caught viaNodeInstance.on('stdout', (data) => { stdout.push(data); });it is always caught viaInspectorSession.waitForConsoleOutput('log', 'safe to debug now');This behavior seems to be random, and by the looks of it, it's related to watch mode in a more general way, not directly related to these tests. It should probably be addressed in a separate issue and PR.
Refs: #44898