-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: do not define wasi
on global with no flag
#45595
Merged
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cola119
changed the title
repl: do not defined
repl: do not define Nov 23, 2022
wasi
on global with no flagwasi
on global with no flag
aduh95
reviewed
Nov 23, 2022
BridgeAR
approved these changes
Nov 23, 2022
cjihrig
approved these changes
Nov 23, 2022
aduh95
approved these changes
Nov 23, 2022
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 23, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 23, 2022
lpinca
approved these changes
Nov 23, 2022
aduh95
approved these changes
Nov 23, 2022
16 tasks
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 25, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45595 ✔ Done loading data for nodejs/node/pull/45595 ----------------------------------- PR info ------------------------------------ Title repl: do not define `wasi` on global with no flag (#45595) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cola119:fix-45560 -> nodejs:main Labels repl, author ready, needs-ci Commits 1 - repl: do not define `wasi` on global with no flag Committers 1 - cola119 PR-URL: https://github.com/nodejs/node/pull/45595 Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45595 Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 23 Nov 2022 08:48:35 GMT ✔ Approvals: 4 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1191699283 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1191760663 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45595#pullrequestreview-1192375682 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45595#pullrequestreview-1192246419 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-23T22:44:37Z: https://ci.nodejs.org/job/node-test-pull-request/48141/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - repl: do not define `wasi` on global with no flag - Querying data for job/node-test-pull-request/48141/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3546553264 |
nodejs-github-bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Nov 25, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 25, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 25, 2022
21 tasks
cola119
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Nov 26, 2022
cola119
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 26, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 26, 2022
Landed in 5a8895c |
This was referenced Nov 27, 2022
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Nov 30, 2022
PR-URL: nodejs#45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 1, 2022
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
repl
Issues and PRs related to the REPL subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45560
In the REPL,
prepareMainThreadExecution
that updates thecanBeRequiredByUsers
flag ofwasi
module according to the flag is called after theinternal/process/esm_loader.js
load that createsbuiltinModules
depending on themodule.canBeRequiredByUsers
flag. In this case,wasi.canBeRequiredByUsers
is alwaystrue
sowasi
module always can be required by users even if the flag is not set.node/lib/internal/modules/cjs/loader.js
Lines 217 to 223 in 2a7635f