-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add options
parameter to eventTarget.removeEventListener
#45667
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221129_add_options_removeeventlistener
Nov 29, 2022
Merged
doc: add options
parameter to eventTarget.removeEventListener
#45667
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:221129_add_options_removeeventlistener
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options parameter is available for eventTarget.removeEventListener, but it's not described.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
events
Issues and PRs related to the events subsystem / EventEmitter.
labels
Nov 28, 2022
daeyeon
approved these changes
Nov 29, 2022
aduh95
approved these changes
Nov 29, 2022
aduh95
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Nov 29, 2022
Fast-track has been requested by @aduh95. Please 👍 to approve. |
MoLow
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2022
Landed in 016abb6 |
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Nov 30, 2022
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: nodejs#45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: #45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: #45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: #45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: #45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: #45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: #45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
events
Issues and PRs related to the events subsystem / EventEmitter.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options parameter is available for eventTarget.removeEventListener, but it's not described.